Migrate cdylib-dylib-linkage run-make test to rmake

[Oneirical]

Part of #121876 and the associated Google Summer of Code project.

Those sysroot tests are always fun. I'm getting local errors that don't make a lot of sense about my own sysroot not existing, so I am trying this in CI to see what happens.

EDIT: I am getting the same error here. The strange thing is, when I try to navigate to /checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib on my personal computer, the directory does exist, but the error message is that the directory does not.

EDIT 2: The sysroot path just needed to be trimmed!

Please try:

// try-job: x86_64-msvc // passed previously
try-job: x86_64-mingw
try-job: x86_64-gnu-llvm-18
try-job: i686-msvc
try-job: aarch64-apple

[rustbot]

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[jieyouxu]

I'll take a look at this (eventually™), I'm looking at some other PRs that also need some holy water.

[jieyouxu]

uh... does the sysroot path have a newline?

the directory in path "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2
/lib/rustlib/x86_64-unknown-linux-gnu/lib" could not be read: Os { code: 2, kind: NotFound, message: "No such file or directory" }

[rustbot]

The run-make-support library was changed

cc @jieyouxu

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

[jieyouxu]

@bors try

[bors]

⌛ Trying commit 648ce51 with merge e44eb08...

[bors]

☀️ Try build successful - checks-actions
Build commit: e44eb08 (e44eb08bad6851782de8d67ff7cf15f75fdce9a6)

[jieyouxu]

@bors try

[bors]

⌛ Trying commit 648ce51 with merge c34ae38...

[bors]

💔 Test failed - checks-actions

[Oneirical]

The dynamic library std filter was incorrect - it was only looking for files that are "not an rlib, with std in the name somewhere", which could include rmeta files. This new implementation explicitly looks for dylibs with std in their filename.

Please try again. @rustbot review

[jieyouxu]

@bors try

[jieyouxu]

Thanks, just a few suggestions

[jieyouxu]

@rustbot author

[Oneirical]

@rustbot review

[jieyouxu]

Thanks, a few more nits then r=me.

[jieyouxu]

@bors delegate+

[bors]

✌️ @Oneirical, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

[jieyouxu]

@bors rollup=iffy

[jieyouxu]

@rustbot author

[bors]

☔ The latest upstream changes (presumably #128356) made this pull request unmergeable. Please resolve the merge conflicts.

[Oneirical]

@bors r=@jieyouxu

[bors]

📌 Commit 20332da has been approved by jieyouxu

It is now in the queue for this repository.

[bors]

⌛ Testing commit 20332da with merge 60d1465...

[bors]

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 60d1465 to master...

[rust-timer]

Finished benchmarking commit (60d1465): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.8%	[2.8%, 2.8%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.8%	[2.8%, 2.8%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 760.454s -> 760.99s (0.07%)
Artifact size: 336.90 MiB -> 336.87 MiB (-0.01%)