-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize offset_of_nested #128284
Stabilize offset_of_nested #128284
Conversation
rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer |
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
@rustbot review (FCP is now complete) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
compiler and tests/
changes LGTM, r=me for those changes
Rolling a T-libs-api reviewer for the libs changes |
This comment has been minimized.
This comment has been minimized.
31aa106
to
23f46e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@bors r+ |
@bors r- |
@bors r=dtolnay,jieyouxu |
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#126247 (rustdoc: word wrap CamelCase in the item list table and sidebar) - rust-lang#128104 (Not lint pub structs without pub constructors intentionally) - rust-lang#128153 (Stop using `MoveDataParamEnv` for places that don't need a param-env) - rust-lang#128284 (Stabilize offset_of_nested) - rust-lang#128342 (simplify the use of `CiEnv`) - rust-lang#128355 (triagebot: make sure Nora is called Nora) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#128284 - GKFX:stabilize-offset-of-nested, r=dtolnay,jieyouxu Stabilize offset_of_nested Tracking issue rust-lang#120140. Closes rust-lang#120140. As the FCP is now nearing its end I have opened a stabilization PR. I have done this separately to the offset_of_enum feature, since that FCP has not started. `@rustbot` label F-offset_of_nested T-lang T-libs-api
Tracking issue #120140. Closes #120140.
As the FCP is now nearing its end I have opened a stabilization PR. I have done this separately to the offset_of_enum feature, since that FCP has not started.
@rustbot label F-offset_of_nested T-lang T-libs-api