Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #128504

Merged
merged 19 commits into from
Aug 1, 2024
Merged

Rollup of 6 pull requests #128504

merged 19 commits into from
Aug 1, 2024

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Hoverbear and others added 19 commits July 8, 2024 11:46
This silences this rust-analyzer-specific error: `expected !, found ()`

Signed-off-by: Martin Kröning <[email protected]>
…unknown-linux-target-page, r=pietroalbini

Add target page for riscv64gc-unknown-linux-gnu

I was reading rust-lang#113739 and realized I knew most of the information necessary to create the `riscv64gc-unknown-linux-gnu` target page.
…fe_fn, r=joboet

fix(hermit): `deny(unsafe_op_in_unsafe_fn)`

Tracking issue: rust-lang#127747

r? workingjubilee

CC: ``@stlankes``
interpret: on a signed deref check, mention the right pointer in the error

When a negative offset (like `ptr.offset(-10)`) goes out-of-bounds, we currently show an error saying that we expect the *resulting* pointer to be inbounds for 10 bytes. That's confusing, so this PR makes it so that instead we say that we expect the *original* pointer `ptr` to have 10 bytes *to the left*.

I also realized I can simplify the pointer arithmetic logic and handling of "staying inbounds of a target `usize`" quite a bit; the second commit does that.
…compiler-errors

Fix removed `box_syntax` diagnostic if source isn't available

Fix rust-lang#128442
fix dropck documentation for `[T;0]` special-case

fixes rust-lang#110288.

r? ``@lcnr``
…ing, r=tgross35

chore: refactor backtrace formatting

Replace `write_str()` with the `writeln!()` macro, consolidating multiple write operations.
@rustbot rustbot added O-hermit Operating System: Hermit S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Aug 1, 2024
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=6

@bors
Copy link
Contributor

bors commented Aug 1, 2024

📌 Commit e6b6d04 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 1, 2024
@bors
Copy link
Contributor

bors commented Aug 1, 2024

⌛ Testing commit e6b6d04 with merge a886938...

@bors
Copy link
Contributor

bors commented Aug 1, 2024

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing a886938 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 1, 2024
@bors bors merged commit a886938 into rust-lang:master Aug 1, 2024
7 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Aug 1, 2024
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#127490 Add target page for riscv64gc-unknown-linux-gnu 6eacff8e602e45b3236c6c10123ba7fb3103da23 (link)
#128433 fix(hermit): deny(unsafe_op_in_unsafe_fn) 4b40399be8b4b9ac498ab7d517d944d0d3a4cc5e (link)
#128482 interpret: on a signed deref check, mention the right point… 8f8bda4d67f2b69fc7edf2eb1527ee415c9261ca (link)
#128496 Fix removed box_syntax diagnostic if source isn't availab… 00a96b7d6eb1febf748adcc1a2329367ae054d07 (link)
#128497 fix dropck documentation for [T;0] special-case 858134783d1763b5fe51259bb2bcc76348d4b08d (link)
#128499 chore: refactor backtrace formatting 9452b297e08c78a054f953bcb4c8cc2ce9401e8d (link)

previous master: e60ebb2f2c

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a886938): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.4% [-0.5%, -0.3%] 12
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 756.054s -> 759.172s (0.41%)
Artifact size: 336.95 MiB -> 336.79 MiB (-0.05%)

@matthiaskrgr matthiaskrgr deleted the rollup-pawylnk branch September 1, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. O-hermit Operating System: Hermit rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants