Autodiff Upstreaming - enzyme backend #129176

ZuseZ4 · 2024-08-17T00:18:26Z

Tracking issue: #124509

This PR should allow building Enzyme from source on Tier 1 targets (when also building LLVM), except MSVC.
It's only a small fraction (~200 lines) of the whole upstream PR, but due to bootstrapping and the number of configurations in which rustc can be build I assume that this will be the hardest to merge, so I'm starting with it.
Happy to hear what changes are required to be able to upstream this code.

Content:
It contains a new configure flag --enable-llvm-enzyme, and will build the new Enzyme submodule when it is set.

Discussion:
Apparently Rust CI isn't able to clone repositories outside the rust-lang org? At least I'm seeing this error in CI:

[email protected]: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Does that mean we would need to mirror github.com/EnzymeAD/Enzyme in rust-lang, until LLVM upgrades Enzyme from an Incubator project to something that ships as part of the monorepo?

Tracking:

Tracking Issue for autodiff #124509

rustbot · 2024-08-17T00:18:34Z

r? @albertlarsan68

rustbot has assigned @albertlarsan68.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-08-17T00:18:35Z

⚠️ Warning ⚠️

These commits modify submodules.

Kobzol · 2024-08-17T09:12:36Z

Use HTTPS instead of SSH authentication for the git repo, then it should work.

.gitmodules

src/bootstrap/src/core/build_steps/compile.rs

Kobzol · 2024-08-17T11:09:10Z

You should probably add an ignore for the enzyme submodule in tidy.

rustbot · 2024-08-17T17:06:26Z

This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp.

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

ZuseZ4 · 2024-08-17T20:44:46Z

Thank you two for already having looked at it. CI passes now, how would we continue?

We probably only want to configure the llvm_enzyme flag as enabled for nightly builds shipped to users once all the other code including tests are moved over to rustc. So from my side, I would be fine with squashing and merging this and putting up the next PR which would include our autodiff rustc_builtin_macro. The frontend is pretty lightweight to build, so we could already enable it by default and just error out in the middle-end, similar to how f128 did it (still do it?).

src/bootstrap/src/core/build_steps/llvm.rs

rustbot · 2024-08-18T08:08:52Z

This PR modifies config.example.toml.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

rustbot · 2024-08-18T08:14:04Z

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git pull --rebase https:/rust-lang/rust.git master
$ git push --force-with-lease

The following commits are merge commits:

2bb72b2

ZuseZ4 · 2024-08-18T08:29:47Z

I guess I shouldn't use the GUI here to resolve merge conflicts, lesson learned.
I intend clean the history up once this PR got approved to not disturb anyone reviewing, but I can also do it now if anyone prefers that.
(I had picked 4 more lines (in src/bootstrap/configure.py and config.example.toml) from the full PR to this one and adjusted the change_tracker accordingly based on the bot feedback I got above, but this caused the merge conflict).

traviscross · 2024-09-04T21:38:23Z

@bors r=albertlarsan68

bors · 2024-09-04T21:38:25Z

📌 Commit 14e8f45 has been approved by albertlarsan68

It is now in the queue for this repository.

traviscross · 2024-09-04T21:38:53Z

@bors rollup=never

Co-authored-by: Lorenz Schmidt <[email protected]>

traviscross · 2024-09-06T05:05:39Z

@bors r=albertlarsan68 p=1

(This seems likely to attract conflicts. The latest push was due to such a conflict developing while in queue.)

bors · 2024-09-06T05:05:41Z

📌 Commit 4f5c16d has been approved by albertlarsan68

It is now in the queue for this repository.

bors · 2024-09-06T05:34:02Z

⌛ Testing commit 4f5c16d with merge f6e192a...

…san68 Autodiff Upstreaming - enzyme backend Tracking issue: rust-lang#124509 Part of rust-lang#129175 This PR should allow building Enzyme from source on Tier 1 targets (when also building LLVM), except MSVC. It's only a small fraction (~200 lines) of the whole upstream PR, but due to bootstrapping and the number of configurations in which rustc can be build I assume that this will be the hardest to merge, so I'm starting with it. Happy to hear what changes are required to be able to upstream this code. **Content:** It contains a new configure flag `--enable-llvm-enzyme`, and will build the new Enzyme submodule when it is set. **Discussion:** Apparently Rust CI isn't able to clone repositories outside the rust-lang org? At least I'm seeing this error in CI: ``` [email protected]: Permission denied (publickey). fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. ``` Does that mean we would need to mirror github.com/EnzymeAD/Enzyme in rust-lang, until LLVM upgrades Enzyme from an Incubator project to something that ships as part of the monorepo? Tracking: - rust-lang#124509

rust-log-analyzer · 2024-09-06T07:17:02Z

The job x86_64-msvc-ext failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[RUSTC-TIMING] miri test:false 4.457
error: failed to remove file `C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage1-tools\x86_64-pc-windows-msvc\release\miri.exe`

Caused by:
  Access is denied. (os error 5)
Command has failed. Rerun with -v to see more details.
  local time: Fri, Sep  6, 2024  7:16:49 AM
  network time: Fri, 06 Sep 2024 07:16:49 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

bors · 2024-09-06T07:17:42Z

💔 Test failed - checks-actions

traviscross · 2024-09-06T07:23:09Z

@bors retry

cc #127883

bors · 2024-09-06T09:42:41Z

⌛ Testing commit 4f5c16d with merge 59d4114...

bors · 2024-09-06T12:08:03Z

☀️ Test successful - checks-actions
Approved by: albertlarsan68
Pushing 59d4114 to master...

rust-timer · 2024-09-06T15:11:45Z

Finished benchmarking commit (59d4114): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.6%	[-3.6%, -3.6%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 2.2%, secondary -2.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.2%	[2.2%, 2.2%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.4%	[-2.6%, -2.1%]	2
All ❌✅ (primary)	2.2%	[2.2%, 2.2%]	1

Cycles

Results (secondary 2.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.7%	[2.3%, 3.0%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 754.927s -> 756.647s (0.23%)
Artifact size: 340.95 MiB -> 340.92 MiB (-0.01%)

rustbot assigned albertlarsan68 Aug 17, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 17, 2024

This comment has been minimized.

Sign in to view

ZuseZ4 changed the title ~~enzyme backend~~ Autodiff Upstreaming - enzyme backend Aug 17, 2024

ZuseZ4 mentioned this pull request Aug 17, 2024

Autodiff Upstreaming - single commit #129175

Draft

Urgau reviewed Aug 17, 2024

View reviewed changes

.gitmodules Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

Kobzol reviewed Aug 17, 2024

View reviewed changes

src/bootstrap/src/core/build_steps/compile.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

rustbot added the A-testsuite Area: The testsuite used to check the correctness of rustc label Aug 17, 2024

This comment has been minimized.

Sign in to view

ZuseZ4 marked this pull request as ready for review August 17, 2024 17:06

traviscross mentioned this pull request Aug 17, 2024

Tracking Issue for autodiff #124509

Open

9 tasks

jieyouxu reviewed Aug 18, 2024

View reviewed changes

src/bootstrap/src/core/build_steps/llvm.rs Outdated Show resolved Hide resolved

jieyouxu added the F-autodiff `#![feature(autodiff)]` label Aug 18, 2024

rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 18, 2024

ZuseZ4 force-pushed the enzyme-backend branch from 2bb72b2 to f96f6a6 Compare August 18, 2024 11:43

rustbot removed the has-merge-commits PR has merge commits, merge with caution. label Aug 18, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 4, 2024

ZuseZ4 mentioned this pull request Sep 5, 2024

Cannot compile on MacOS: library not found for -lEnzyme-19 EnzymeAD/rust#175

Open

Enzyme backend

4f5c16d

Co-authored-by: Lorenz Schmidt <[email protected]>

ZuseZ4 force-pushed the enzyme-backend branch from 14e8f45 to 4f5c16d Compare September 6, 2024 02:47

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 6, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 6, 2024

bors merged commit 59d4114 into rust-lang:master Sep 6, 2024
7 checks passed

rustbot added this to the 1.83.0 milestone Sep 6, 2024

This was referenced Sep 6, 2024

[bootstrap] Add support for building gcc and libgccjit #125419

Merged

use download-ci-llvm=true in the default compiler config #129473

Merged

ZuseZ4 mentioned this pull request Sep 6, 2024

Timeline for integrating into Rust upstream? EnzymeAD/rust#67

Open

ZuseZ4 deleted the enzyme-backend branch September 11, 2024 19:59

ZuseZ4 mentioned this pull request Sep 20, 2024

tool builds with Enzyme/autodiff fails #130637

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Autodiff Upstreaming - enzyme backend #129176

Autodiff Upstreaming - enzyme backend #129176

ZuseZ4 commented Aug 17, 2024 •

edited

Loading

rustbot commented Aug 17, 2024

rustbot commented Aug 17, 2024

This comment has been minimized.

Kobzol commented Aug 17, 2024 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

Kobzol commented Aug 17, 2024

This comment has been minimized.

This comment has been minimized.

rustbot commented Aug 17, 2024

ZuseZ4 commented Aug 17, 2024 •

edited

Loading

rustbot commented Aug 18, 2024

rustbot commented Aug 18, 2024

ZuseZ4 commented Aug 18, 2024 •

edited

Loading

traviscross commented Sep 4, 2024

bors commented Sep 4, 2024

traviscross commented Sep 4, 2024

traviscross commented Sep 6, 2024

bors commented Sep 6, 2024

bors commented Sep 6, 2024

rust-log-analyzer commented Sep 6, 2024

bors commented Sep 6, 2024

traviscross commented Sep 6, 2024

bors commented Sep 6, 2024

bors commented Sep 6, 2024

rust-timer commented Sep 6, 2024

Autodiff Upstreaming - enzyme backend #129176

Autodiff Upstreaming - enzyme backend #129176

Conversation

ZuseZ4 commented Aug 17, 2024 • edited Loading

rustbot commented Aug 17, 2024

rustbot commented Aug 17, 2024

This comment has been minimized.

Kobzol commented Aug 17, 2024 • edited Loading

This comment has been minimized.

This comment has been minimized.

Kobzol commented Aug 17, 2024

This comment has been minimized.

This comment has been minimized.

rustbot commented Aug 17, 2024

ZuseZ4 commented Aug 17, 2024 • edited Loading

rustbot commented Aug 18, 2024

rustbot commented Aug 18, 2024

ZuseZ4 commented Aug 18, 2024 • edited Loading

traviscross commented Sep 4, 2024

bors commented Sep 4, 2024

traviscross commented Sep 4, 2024

traviscross commented Sep 6, 2024

bors commented Sep 6, 2024

bors commented Sep 6, 2024

rust-log-analyzer commented Sep 6, 2024

bors commented Sep 6, 2024

traviscross commented Sep 6, 2024

bors commented Sep 6, 2024

bors commented Sep 6, 2024

rust-timer commented Sep 6, 2024

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

ZuseZ4 commented Aug 17, 2024 •

edited

Loading

Kobzol commented Aug 17, 2024 •

edited

Loading

ZuseZ4 commented Aug 17, 2024 •

edited

Loading

ZuseZ4 commented Aug 18, 2024 •

edited

Loading