Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert MSVC CI changes #131133

Closed
wants to merge 4 commits into from
Closed

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented Oct 2, 2024

We finished updating all major lockfiles to a cc version that includes rust-lang/cc-rs#1215. See if this allows us to revert CI changes that were made to help #127883.

try-job: x86_64-msvc
try-job: x86_64-msvc-ext

r? @ghost

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Oct 2, 2024
@tgross35 tgross35 marked this pull request as draft October 2, 2024 03:39
@tgross35
Copy link
Contributor Author

tgross35 commented Oct 2, 2024

@bors try

@bors
Copy link
Contributor

bors commented Oct 2, 2024

⌛ Trying commit 343579b with merge 808abc9...

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 2, 2024
…try>

Revert MSVC CI changes

- rust-lang#130151
- rust-lang#130072

try-job: x86_64-msvc
try-job: x86_64-msvc-ext
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 2, 2024
…=<try>

[experiment] Revert msvc ci changes 2

Duplicate of rust-lang#131133 so we can have two try jobs going at once.

r? `@ghost`

try-job: x86_64-msvc
try-job: x86_64-msvc-ext
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-msvc-ext failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
Updating files:  99% (49347/49845)
Updating files:  99% (49485/49845)
Updating files: 100% (49845/49845)
Updating files: 100% (49845/49845), done.
branch 'try' set up to track 'origin/try'.
Switched to a new branch 'try'
[command]"C:\Program Files\Git\bin\git.exe" log -1 --format='%H'
'808abc9ed6c605c5990283876dcaa08605c90b5f'
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
---
file:.git/config remote.origin.url=https:/rust-lang-ci/rust
file:.git/config remote.origin.fetch=+refs/heads/*:refs/remotes/origin/*
file:.git/config gc.auto=0
file:.git/config http.https:/.extraheader=AUTHORIZATION: basic ***
file:.git/config branch.try.remote=origin
file:.git/config branch.try.merge=refs/heads/try
file:.git/config submodule.library/backtrace.url=https:/rust-lang/backtrace-rs.git
file:.git/config submodule.library/stdarch.active=true
file:.git/config submodule.library/stdarch.url=https:/rust-lang/stdarch.git
file:.git/config submodule.src/doc/book.active=true
---
       2:     0x7ff9028aaa51 - <std::io::IoSlice as core::fmt::Debug>::fmt::h4a182e8c3a16b3db
       3:     0x7ff9028b43e5 - std::sys::backtrace::lock::hdca5b1abd2ab3bbc
       4:     0x7ff9028b7ca6 - std::panicking::default_hook::hc8b64950fb9cc855
       5:     0x7ff9028b7983 - std::panicking::default_hook::hc8b64950fb9cc855
       6:     0x7ff8fab967f5 - RINvXs1u_NtCs5wgFO3o6jsS_9hashbrown3mapINtB7_7HashMapNtNtNtCsfF6KGZULuuB_18rustc_query_system9dep_graph5graph12DepNodeIndexuINtNtCs6kzId26JLnn_4core4hash18BuildHasherDefaultNtCs12N8qz854pM_10rustc_hash8FxHasherEEINtNtNtNtB23_4iter6traits7collect6ExtendTBP_
       8:     0x7ff9028b8319 - <std::panicking::begin_panic_handler::StaticStrPayload as core::fmt::Display>::fmt::h8d2f3c5b3ff174b0
       9:     0x7ff9028b4f2f - <std::sys::backtrace::BacktraceLock::print::DisplayBacktrace as core::fmt::Display>::fmt::ha58047d961363fe3
      10:     0x7ff9028b7e9e - rust_begin_unwind
      11:     0x7ff902ca0851 - core::panicking::panic_fmt::ha2b2c5c2eabe157c
      11:     0x7ff902ca0851 - core::panicking::panic_fmt::ha2b2c5c2eabe157c
      12:     0x7ff902ca0d47 - core::panicking::assert_failed_inner::h3dc7b5bb29816b36
      13:     0x7ff9029a46db - RINvNtCs6kzId26JLnn_4core9panicking13assert_failedINtNtB4_6option6OptionINtNtCshwP0RL9S7Jj_13rustc_type_ir6binder6BinderNtNtNtCsfUGnoeEJq4c_12rustc_middle2ty7context6TyCtxtINtNtB1d_9predicate19ExistentialTraitRefB1U_EEEBM_ECs4xzSLBGK2pq_18rustc_codegen_llv
      14:     0x7ff8fb1ff8d5 - rustc_codegen_ssa[5811628fbe716a9f]::base::unsize_ptr::<rustc_codegen_llvm[34e613f8f085f082]::builder::Builder>
      15:     0x7ff8fb1ff055 - rustc_codegen_ssa[5811628fbe716a9f]::base::unsize_ptr::<rustc_codegen_llvm[34e613f8f085f082]::builder::Builder>
      16:     0x7ff8fb1e5616 - <itertools[c770c535ea7b42e5]::lazy_buffer::LazyBuffer<core[49c04ffffedd355f]::array::iter::IntoIter<rustc_sanitizers[7131a96a50b0b1b4]::cfi::typeid::TypeIdOptions, 3usize>>>::get_next
      17:     0x7ff8fb1d9da6 - rustc_codegen_ssa[5811628fbe716a9f]::mir::codegen_mir::<rustc_codegen_llvm[34e613f8f085f082]::builder::Builder>
      18:     0x7ff8fb201884 - rustc_codegen_ssa[5811628fbe716a9f]::base::codegen_instance::<rustc_codegen_llvm[34e613f8f085f082]::builder::Builder>
      19:     0x7ff8fb06c0e7 - <rustc_middle[b95cf50418db8646]::mir::mono::MonoItem as rustc_codegen_ssa[5811628fbe716a9f]::mono_item::MonoItemExt>::define::<rustc_codegen_llvm[34e613f8f085f082]::builder::Builder>
      20:     0x7ff8fb11a1c2 - rustc_codegen_llvm[34e613f8f085f082]::base::compile_codegen_unit
      21:     0x7ff8fb118cd7 - rustc_codegen_llvm[34e613f8f085f082]::base::compile_codegen_unit
      22:     0x7ff8fb20080a - rustc_codegen_ssa[5811628fbe716a9f]::base::codegen_crate::<rustc_codegen_llvm[34e613f8f085f082]::LlvmCodegenBackend>
      23:     0x7ff8fb00aa77 - <rustc_codegen_llvm[34e613f8f085f082]::LlvmCodegenBackend as rustc_codegen_ssa[5811628fbe716a9f]::traits::backend::CodegenBackend>::codegen_crate
      24:     0x7ff8fadb9670 - rustc_interface[22e6e4b4cca3fb7a]::passes::start_codegen
      25:     0x7ff8fadf0f8b - <rustc_interface[22e6e4b4cca3fb7a]::queries::Linker>::codegen_and_build_linker
      26:     0x7ff8faa9c216 - RINvMsh_NtNtCsfUGnoeEJq4c_12rustc_middle2ty7contextNtB6_10GlobalCtxt5enterNCNCNCNvCs5HvIzKodCYs_17rustc_driver_impl12run_compiler0s_0s4_0INtNtCs6kzId26JLnn_4core6result6ResultINtNtB2g_6option6OptionNtNtCs2ZMuxQxPiJi_15rustc_interface7queries6LinkerENtCs5Yv
      27:     0x7ff8faaec1d9 - RINvMs1_NtCs2ZMuxQxPiJi_15rustc_interface7queriesINtB6_11QueryResultRNtNtNtCsfUGnoeEJq4c_12rustc_middle2ty7context10GlobalCtxtE5enterINtNtCs6kzId26JLnn_4core6result6ResultINtNtB2c_6option6OptionNtB6_6LinkerENtCs5YvPijYSZ18_10rustc_span15ErrorGuaranteedENCN
      28:     0x7ff8fab22ddd - RINvMs4_NtCs2ZMuxQxPiJi_15rustc_interface7queriesNtNtB8_9interface8Compiler5enterNCNCNvCs5HvIzKodCYs_17rustc_driver_impl12run_compiler0s_0INtNtCs6kzId26JLnn_4core6result6ResultINtNtB2h_6option6OptionNtB6_6LinkerENtCs5YvPijYSZ18_10rustc_span15ErrorGuarantee
      29:     0x7ff8fab551c1 - RINvMs_Cs6QFZIbb7Pac_10scoped_tlsINtB5_9ScopedKeyNtCs5YvPijYSZ18_10rustc_span14SessionGlobalsE3setNCNCNCINvNtCs2ZMuxQxPiJi_15rustc_interface4util26run_in_thread_with_globalsNCINvB1H_31run_in_thread_pool_with_globalsNCINvNtB1J_9interface12run_compilerINtNtC
      30:     0x7ff8faaaa93a - RINvCs5YvPijYSZ18_10rustc_span27create_session_globals_thenINtNtCs6kzId26JLnn_4core6result6ResultuNtB2_15ErrorGuaranteedENCNCNCINvNtCs2ZMuxQxPiJi_15rustc_interface4util26run_in_thread_with_globalsNCINvB24_31run_in_thread_pool_with_globalsNCINvNtB26_9interf
      31:     0x7ff8faa8f3db - RINvNtNtCs5U8bFklc8S4_3std3sys9backtrace28___rust_begin_short_backtraceNCNCINvNtCs2ZMuxQxPiJi_15rustc_interface4util26run_in_thread_with_globalsNCINvB1e_31run_in_thread_pool_with_globalsNCINvNtB1g_9interface12run_compilerINtNtCs6kzId26JLnn_4core6result6Res
      32:     0x7ff8fab61f77 - <std[44c88882080b606a]::hash::random::RandomState as core[49c04ffffedd355f]::hash::BuildHasher>::hash_one::<&(intl_pluralrules[4fbe64a0064aab09]::PluralRuleType,)>
      34:     0x7ff940c24cb0 - BaseThreadInitThunk
      35:     0x7ff9429becdb - RtlUserThreadStart
    
    error: the compiler unexpectedly panicked. this is a bug.
---
[RUSTC-TIMING] miri test:false 5.549
error: failed to remove file `C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage1-tools\x86_64-pc-windows-msvc\release\miri.exe`

Caused by:
  Access is denied. (os error 5)
Command has failed. Rerun with -v to see more details.
  local time: Wed, Oct  2, 2024  5:26:05 AM
  network time: Wed, 02 Oct 2024 05:26:05 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

@bors
Copy link
Contributor

bors commented Oct 2, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 2, 2024
@jieyouxu
Copy link
Member

jieyouxu commented Oct 2, 2024

... Wait, is that an ICE?

@ChrisDenton
Copy link
Member

Yes but it's in an mdbook test which is allowed to fail. The actual failure came later.

@tgross35 tgross35 closed this Oct 12, 2024
@tgross35 tgross35 deleted the revert-msvc-ci-changes branch October 12, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants