Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LLVM compatibility to CONTRIBUTING.md #131622

Closed
wants to merge 1 commit into from

Conversation

manishwalia15
Copy link

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Oct 12, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 12, 2024
@tgross35 tgross35 changed the title Update CONTRIBUTING.md Add LLVM compatibility to CONTRIBUTING.md Oct 12, 2024
@Mark-Simulacrum
Copy link
Member

r? llvm

My sense is that this is probably not going to be kept up to date, which makes it not very useful. I'm also not sure we have any real policy on this -- my sense is that the versions are really just "whatever is tested in our CI"?

@rustbot
Copy link
Collaborator

rustbot commented Oct 12, 2024

Failed to set assignee to llvm: cannot assign: response: {"message":"Not Found","documentation_url":"https://docs.github.com/rest/issues/assignees#add-assignees-to-an-issue","status":"404"}

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@workingjubilee
Copy link
Member

@manishwalia15 Please do not open a new PR for every revision.

@slanterns
Copy link
Contributor

#131619 (comment)


To build `rustc`, it is important to know which versions of LLVM are supported. As of Rust 1.82, the following external LLVM versions are supported:

- **Minimum Supported Version**: LLVM 17
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still not the right version, we don't support LLVM 17 anymore. Where are you getting this information?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mybe

@manishwalia15
Copy link
Author

Kindly tell where is the mistake

@workingjubilee
Copy link
Member

See: #130487

The minimum was raised to LLVM 18.

@manishwalia15
Copy link
Author

manishwalia15 commented Oct 12, 2024

shall i update to 18..rest is fine ?
pls tell @workingjubilee

@slanterns
Copy link
Contributor

slanterns commented Oct 12, 2024

Maybe we should figure out if it's truly helpful to add this to CONTRIBUTING.md first.

@manishwalia15
Copy link
Author

Please do tell

@nikic
Copy link
Contributor

nikic commented Oct 12, 2024

https:/rust-lang/rust/blob/master/INSTALL.md#dependencies would be a more appropriate place.

@manishwalia15
Copy link
Author

@nikic #131627
i hv done kindly see

@slanterns
Copy link
Contributor

slanterns commented Oct 12, 2024

You can update your PR instead of opening a new one each time.

@manishwalia15
Copy link
Author

sorry @slanterns i didn knew
next time i wont
please allow for this time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants