Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fast-path when computing the default visibility #131686

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented Oct 14, 2024

This PR adds (or more correctly re-adds the) fast-path when computing the default visibility, by taking advantage of the fact that the "interposable" requested visibility always return the "default" codegen visibility.

Should address the small regression observed in #131111 (comment).

r? @lqd

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 14, 2024
@lqd
Copy link
Member

lqd commented Oct 14, 2024

As cachegrind showed the small regressions in #130005 to be purely in the query system, I'm fully confident that the new unconditional query call to the expensive query was the source.

So, r=me with green perf and/or a cachegrind comparison between this and #130005 (or its parent commit). I expect the "PROGRAM TOTALS" line on a cg report for this PR to be the same as before the change was made.

@Urgau
Copy link
Member Author

Urgau commented Oct 14, 2024

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 14, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 14, 2024
Add fast-path when computing the default visibility

This PR adds (or more correctly re-adds the) fast-path when computing the default visibility, by taking advantage of the fact that the "interposable" requested visibility always return the "default" codegen visibility.

Should address the small regression observed in rust-lang#131111 (comment).

r? `@lqd`
@bors
Copy link
Contributor

bors commented Oct 14, 2024

⌛ Trying commit 67b85e2 with merge 701880a...

@bors
Copy link
Contributor

bors commented Oct 14, 2024

☀️ Try build successful - checks-actions
Build commit: 701880a (701880a6fab37ed2f0c178997183a43fe182dac0)

@rust-timer
Copy link
Collaborator

Queued 701880a with parent f6648f2, future comparison URL.
There are currently 0 preceding artifacts in the queue.
It will probably take at least ~1.2 hours until the benchmark run finishes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-perf Status: Waiting on a perf run to be completed. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants