-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rolling up PRs in the queue #13290
Closed
Closed
Rolling up PRs in the queue #13290
Commits on Apr 3, 2014
-
rustc: Stop using LLVMGetSectionName
The recent pull request to remove libc from libstd has hit a wall in compiling on windows, and I've been trying to investigate on the try bots as to why (it compiles locally just fine). To the best of my knowledge, the LLVM section iterator is behaving badly when iterating over the sections of the libc DLL. Upon investigating the LLVMGetSectionName function in LLVM, I discovered that this function doesn't always return a null-terminated string. It returns the data pointer of a StringRef instance (LLVM's equivalent of &str essentially), but it has no method of returning the length of the name of the section. This commit modifies the section iteration when loading libraries to invoke a custom LLVMRustGetSectionName which will correctly return both the length and the data pointer. I have not yet verified that this will fix landing liblibc, as it will require a snapshot before doing a full test. Regardless, this is a worrisome situation regarding the LLVM API, and should likely be fixed anyway.
Configuration menu - View commit details
-
Copy full SHA for 15e6e8c - Browse repository at this point
Copy the full SHA 15e6e8cView commit details -
rustllvm: Remove a no longer needed file
The .def.in files haven't been necessary since the switch to static linking awhile back.
Configuration menu - View commit details
-
Copy full SHA for 0bd6f2c - Browse repository at this point
Copy the full SHA 0bd6f2cView commit details -
std: override clone_from for Vec.
A vector can reuse its allocation (and the allocations/resources of any contained values) when cloning into an already-instantiated vector, so we might as well do so.
Configuration menu - View commit details
-
Copy full SHA for f5a4837 - Browse repository at this point
Copy the full SHA f5a4837View commit details -
Configuration menu - View commit details
-
Copy full SHA for 696a005 - Browse repository at this point
Copy the full SHA 696a005View commit details -
Configuration menu - View commit details
-
Copy full SHA for 74ae36c - Browse repository at this point
Copy the full SHA 74ae36cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 35ed58c - Browse repository at this point
Copy the full SHA 35ed58cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b4f7b6d - Browse repository at this point
Copy the full SHA b4f7b6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ae2924 - Browse repository at this point
Copy the full SHA 2ae2924View commit details -
extern crate
andmod
are not easily confusedRemove some statements that used to refer to similarities between `mod` and `extern mod`, before the latter was renamed to `extern crate`.
Configuration menu - View commit details
-
Copy full SHA for c1e52c7 - Browse repository at this point
Copy the full SHA c1e52c7View commit details -
Fix reference to "these two traits."
There are actually three traits listed.
Configuration menu - View commit details
-
Copy full SHA for 544516a - Browse repository at this point
Copy the full SHA 544516aView commit details -
Minor spelling/grammar/usage fixes.
Note: "different to" is not exactly incorrect, but "different from" is more commonly accepted in both US and Commonwealth English, and also more consistent with other usage within this tutorial.
Configuration menu - View commit details
-
Copy full SHA for 1ac8b34 - Browse repository at this point
Copy the full SHA 1ac8b34View commit details -
1778b63 provided the guarantee of no `exchange_free` calls for ~ZeroSizeType, so a sentinel can now be used without overhead. Closes rust-lang#11998
Configuration menu - View commit details
-
Copy full SHA for 898669c - Browse repository at this point
Copy the full SHA 898669cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a1c47b - Browse repository at this point
Copy the full SHA 1a1c47bView commit details -
syntax: Remove AbiSet, use one Abi
This change removes the AbiSet from the AST, converting all usage to have just one Abi value. The current scheme selects a relevant ABI given a list of ABIs based on the target architecture and how relevant each ABI is to that architecture. Instead of this mildly complicated scheme, only one ABI will be allowed in abi strings, and pseudo-abis will be created for special cases as necessary. For example the "system" abi exists for stdcall on win32 and C on win64. Closes rust-lang#10049
Configuration menu - View commit details
-
Copy full SHA for 57e0908 - Browse repository at this point
Copy the full SHA 57e0908View commit details
Commits on Apr 4, 2014
-
5
Configuration menu - View commit details
-
Copy full SHA for 487fa95 - Browse repository at this point
Copy the full SHA 487fa95View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.