run rustfmt on libsyntax_ext folder #34114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
cc @nrc take a look |
| _ => false | ||
| } | ||
| }).unwrap_or(tts.len()); | ||
| let first_colon = tts.iter() |
There was a problem hiding this comment.
@nrc I would love if rustfmt would avoid this kind of indentation (when you have a multi-line closure in the middle of a method chain).
|
I think this is basically fine to land, but has a couple examples where rustfmt ends up pushing things far to the right. It'd be great to have some rules that can avoid this (though I imagine it's not easy). |
| Inputs => Clobbers, | ||
| Clobbers => Options, | ||
| Options => StateNone, | ||
| StateNone => StateNone, | ||
| } |
There was a problem hiding this comment.
is removing the alignment like this ok?
|
☔ The latest upstream changes (presumably #34424) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Closing due to inactivity, but feel free to resubmit with a rebase! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.