Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc_llvm: Require 3.9 for --link-static #37667

Merged
merged 1 commit into from
Nov 10, 2016
Merged

rustc_llvm: Require 3.9 for --link-static #37667

merged 1 commit into from
Nov 10, 2016

Conversation

alexcrichton
Copy link
Member

Apparently stock Ubuntu 16.04 includes LLVM 3.8 which doesn't have this flag.

@alexcrichton
rustc_llvm: Require 3.9 for --link-static
cc2c812 
Apparently stock Ubuntu 16.04 includes LLVM 3.8 which doesn't have this flag.
@alexcrichton alexcrichton mentioned this pull request Nov 9, 2016
Merged
@rust-highfive
Copy link
Collaborator

r? @nrc

(rust_highfive has picked a reviewer for you, use r? to override)

@japaric
Copy link
Member

japaric commented Nov 9, 2016 •
edited
Loading

@bors r+ rollup

cc @pweyck (in case you have any objection)

@bors
Copy link
Contributor

bors commented Nov 9, 2016

📌 Commit cc2c812 has been approved by japaric

@bors
Copy link
Contributor

bors commented Nov 9, 2016

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Nov 9, 2016

📌 Commit cc2c812 has been approved by japaric

@pweyck
Copy link
Contributor

pweyck commented Nov 9, 2016

Sorry about that :-(

Must have mixed up the versions.

eddyb added a commit to eddyb/rust that referenced this pull request Nov 10, 2016
@eddyb
Rollup merge of rust-lang#37667 - alexcrichton:fix-llvm-version, r=ja…
3a5b45a 
…paric

rustc_llvm: Require 3.9 for --link-static

Apparently stock Ubuntu 16.04 includes LLVM 3.8 which doesn't have this flag.
@eddyb eddyb mentioned this pull request Nov 10, 2016
Merged
bors added a commit that referenced this pull request Nov 10, 2016
@bors
Auto merge of #37678 - eddyb:rollup, r=eddyb
b46ce08 
Rollup of 5 pull requests

- Successful merges: #37402, #37412, #37661, #37664, #37667
- Failed merges:
@bors bors merged commit cc2c812 into rust-lang:master Nov 10, 2016
@alexcrichton alexcrichton deleted the fix-llvm-version branch November 11, 2016 22:01
@cuviper
Copy link
Member

cuviper commented Nov 17, 2016

BTW, the mistaken 3.8 condition made it into beta. Might this fix be backported?

@alexcrichton alexcrichton added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 17, 2016
@alexcrichton
Copy link
Member Author

Sure! Nominating for beta

@cuviper
Copy link
Member

cuviper commented Nov 17, 2016

Although now that I think about it, I'm not using rustbuild in Fedora yet, so it won't actually affect me anyway. Still, it's a trivial fix.

@alexcrichton
Copy link
Member Author

Ah ok, in that case we tend to prefer backporting wherever possible (as the fix comes in 6 weeks anyway). In that case I'll un-nominate.

@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nrc nrc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@alexcrichton @rust-highfive @japaric @bors @pweyck @cuviper @nrc