Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor suggestions into a structured form internally #39973

Closed
wants to merge 10 commits into from

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Feb 20, 2017

work towards making #39458 possible without user visible changes.

This PR changes suggestions from being converted to regular diagnostics by the span_suggestion call, and instead moves this to the emit call on the specific emitter (json or command line).

r? @nrc

cc @petrochenkov

@nrc
Copy link
Member

nrc commented Feb 22, 2017

Even though this is not user-visible, I still don't think it is an improvement to add another category of diagnostic to the compiler. As I stated on #39458 I don't think there is any benefit to the guess category.

@rust-lang/compiler thoughts? Do you want another category of diagnostic?

@oli-obk
Copy link
Contributor Author

oli-obk commented Feb 22, 2017

I don't think there is any benefit to the guess category.

Since I disagree and discussing this in an ad-hoc manner (like in #39458) probably won't lead anywhere, would you prefer if I'd open an RFC to have a clean base for discussion?

Even though this is not user-visible

Since json is stable, it is user-visible.

@nikomatsakis
Copy link
Contributor

cc @estebank

@nikomatsakis
Copy link
Contributor

I guess this doesn't really affect the output?

@nrc
Copy link
Member

nrc commented Feb 23, 2017

would you prefer if I'd open an RFC to have a clean base for discussion?

Sure, seems like a good idea - we haven't had a compiler RFC for a while

@alexcrichton
Copy link
Member

I think rust-lang/rfcs#1941 is the corresponding RFC for this now, right? I'm going to close this but if I'm incorrect then just let me know and I'll reopen!

@oli-obk oli-obk deleted the guess_wip_2 branch June 15, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants