Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update libc to 0.2.21 #40317

Merged
merged 4 commits into from
Mar 29, 2017
Merged

Update libc to 0.2.21 #40317

merged 4 commits into from
Mar 29, 2017

Conversation

malbarbo
Copy link
Contributor

@malbarbo malbarbo commented Mar 7, 2017

Update to include android aarch64 and x86 improvements.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Mar 7, 2017

📌 Commit 4fd93df has been approved by alexcrichton

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 8, 2017
@frewsxcv
Rollup merge of rust-lang#40317 - malbarbo:update-libc, r=alexcrichton
e652321 
Update libc to 0.2.21

Update to include android aarch64 and x86 improvements.
@frewsxcv frewsxcv mentioned this pull request Mar 8, 2017
Closed
@frewsxcv
Copy link
Member

frewsxcv commented Mar 8, 2017

This appears to fail on Android:

https://travis-ci.org/rust-lang/rust/jobs/209003929

@bors r-

@malbarbo
Copy link
Contributor Author

@frewsxcv libc 0.2.21 fixed the type of c_char from u8 to i8. I update the c_char on src/libstd/os/raw.rs to i8. This should fix the PR.

@alexcrichton
Copy link
Member

@bors: r+

Thanks!

@bors
Copy link
Contributor

bors commented Mar 16, 2017

📌 Commit 184b9c2 has been approved by alexcrichton

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40317 - malbarbo:update-libc, r=alexcrichton
374dd2a 
Update libc to 0.2.21

Update to include android aarch64 and x86 improvements.
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40317 - malbarbo:update-libc, r=alexcrichton
14ef6a8 
Update libc to 0.2.21

Update to include android aarch64 and x86 improvements.
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Closed
@frewsxcv
Copy link
Member

@bors r-

Looks like there's still an issue here: #40592 (comment)

@malbarbo
Copy link
Contributor Author

I fixed the error.

Run src/ci/docker/run.sh dist-android and it almost worked... the dist tar balls was generated, but I got I error about rustbook:

Rustbook (arm-linux-androideabi) - nomicon
An error occured:
Read-only file system (os error 30)


command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu/release/rustbook" "build" "/checkout/src/doc/nomicon" "-d" "/checkout/obj/build/arm-linux-androideabi/doc/nomicon"
expected success, got: exit code: 101

Maybe a local error?

I also rebased...

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 17, 2017

📌 Commit 3435c60 has been approved by alexcrichton

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40317 - malbarbo:update-libc, r=alexcrichton
b449fda 
Update libc to 0.2.21

Update to include android aarch64 and x86 improvements.
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40317 - malbarbo:update-libc, r=alexcrichton
ef47812 
Update libc to 0.2.21

Update to include android aarch64 and x86 improvements.
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40317 - malbarbo:update-libc, r=alexcrichton
982f155 
Update libc to 0.2.21

Update to include android aarch64 and x86 improvements.
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Closed
@frewsxcv frewsxcv mentioned this pull request Mar 18, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 18, 2017
@frewsxcv
Rollup merge of rust-lang#40317 - malbarbo:update-libc, r=alexcrichton
d85ed11 
Update libc to 0.2.21

Update to include android aarch64 and x86 improvements.
@frewsxcv frewsxcv mentioned this pull request Mar 18, 2017
Closed
@frewsxcv
Copy link
Member

Here's another one: #40629 (comment)

@bors r-

@malbarbo
Copy link
Contributor Author

@alexcrichton Now both src/ci/docker/run.sh arm-android and src/ci/docker/run.sh dist-android run successful in my machine. Let's see how it goes on travis.

@alexcrichton
Copy link
Member

@bors: r+

Ok!

@bors
Copy link
Contributor

bors commented Mar 27, 2017

📌 Commit 24be899 has been approved by alexcrichton

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 27, 2017
@alexcrichton
Rollup merge of rust-lang#40317 - malbarbo:update-libc, r=alexcrichton
e857e29 
Update libc to 0.2.21

Update to include android aarch64 and x86 improvements.
@alexcrichton alexcrichton mentioned this pull request Mar 27, 2017
Merged
bors added a commit that referenced this pull request Mar 27, 2017
@bors
Auto merge of #40867 - alexcrichton:rollup, r=alexcrichton
32a2d73 
Rollup of 19 pull requests

- Successful merges: #40317, #40516, #40524, #40606, #40683, #40751, #40778, #40813, #40818, #40819, #40824, #40828, #40832, #40833, #40837, #40849, #40852, #40853, #40865
- Failed merges:
bors added a commit that referenced this pull request Mar 28, 2017
@bors
Auto merge of #40867 - alexcrichton:rollup, r=alexcrichton
07a3429 
Rollup of 19 pull requests

- Successful merges: #40317, #40516, #40524, #40606, #40683, #40751, #40778, #40813, #40818, #40819, #40824, #40828, #40832, #40833, #40837, #40849, #40852, #40853, #40865
- Failed merges:
@bors bors merged commit 24be899 into rust-lang:master Mar 29, 2017
@jdm jdm mentioned this pull request Mar 29, 2017
Closed
@SimonSapin SimonSapin mentioned this pull request Mar 29, 2017
Closed
@malbarbo malbarbo mentioned this pull request Mar 30, 2017
Closed
@sfackler sfackler mentioned this pull request May 9, 2017
Closed
@hlzhang hlzhang mentioned this pull request May 24, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@malbarbo @rust-highfive @alexcrichton @bors @frewsxcv @brson