-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compact display of static lib dependencies #43067
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,7 +15,7 @@ use super::linker::Linker; | |
use super::rpath::RPathConfig; | ||
use super::rpath; | ||
use metadata::METADATA_FILENAME; | ||
use rustc::session::config::{self, NoDebugInfo, OutputFilenames, OutputType}; | ||
use rustc::session::config::{self, NoDebugInfo, OutputFilenames, OutputType, PrintRequest}; | ||
use rustc::session::filesearch; | ||
use rustc::session::search_paths::PathKind; | ||
use rustc::session::Session; | ||
|
@@ -647,11 +647,20 @@ fn link_staticlib(sess: &Session, | |
ab.build(); | ||
|
||
if !all_native_libs.is_empty() { | ||
sess.note_without_error("link against the following native artifacts when linking against \ | ||
this static library"); | ||
sess.note_without_error("the order and any duplication can be significant on some \ | ||
platforms, and so may need to be preserved"); | ||
if sess.opts.prints.contains(&PrintRequest::NativeStaticLibs) { | ||
print_native_static_libs(sess, &all_native_libs); | ||
} else { | ||
// Fallback for backwards compatibility only | ||
print_native_static_libs_legacy(sess, &all_native_libs); | ||
} | ||
} | ||
} | ||
|
||
fn print_native_static_libs_legacy(sess: &Session, all_native_libs: &[NativeLibrary]) { | ||
sess.note_without_error("link against the following native artifacts when linking against \ | ||
this static library"); | ||
sess.note_without_error("This list will not be printed by default. \ | ||
Please add --print=native-static-libs if you need this information"); | ||
|
||
for lib in all_native_libs.iter().filter(|l| relevant_lib(sess, l)) { | ||
let name = match lib.kind { | ||
|
@@ -665,6 +674,35 @@ fn link_staticlib(sess: &Session, | |
} | ||
} | ||
|
||
fn print_native_static_libs(sess: &Session, all_native_libs: &[NativeLibrary]) { | ||
let lib_args: Vec<_> = all_native_libs.iter() | ||
.filter(|l| relevant_lib(sess, l)) | ||
.filter_map(|lib| match lib.kind { | ||
NativeLibraryKind::NativeStaticNobundle | | ||
NativeLibraryKind::NativeUnknown => { | ||
if sess.target.target.options.is_like_msvc { | ||
Some(format!("{}.lib", lib.name)) | ||
} else { | ||
Some(format!("-l{}", lib.name)) | ||
} | ||
}, | ||
NativeLibraryKind::NativeFramework => { | ||
// ld-only syntax, since there are no frameworks in MSVC | ||
Some(format!("-framework {}", lib.name)) | ||
}, | ||
// These are included, no need to print them | ||
NativeLibraryKind::NativeStatic => None, | ||
}) | ||
.collect(); | ||
if !lib_args.is_empty() { | ||
sess.note_without_error("Link against the following native artifacts when linking \ | ||
against this static library. The order and any duplication \ | ||
can be significant on some platforms."); | ||
// Prefix for greppability | ||
sess.note_without_error(format!("native-static-libs: {}", &lib_args.join(" "))); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing an [00:14:11] error[E0308]: mismatched types
[00:14:11] --> /checkout/src/librustc_trans/back/link.rs:702:33
[00:14:11] |
[00:14:11] 702 | sess.note_without_error(format!("native-static-libs: {}", &lib_args.join(" ")));
[00:14:11] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected &str, found struct `std::string::String`
[00:14:11] |
[00:14:11] = note: expected type `&str`
[00:14:11] found type `std::string::String`
[00:14:11] = help: try with `&format!("native-static-libs: {}", &lib_args.join(" "))`
[00:14:11] = note: this error originates in a macro outside of the current crate
[00:14:11]
[00:14:15] error: aborting due to previous error
[00:14:15]
[00:14:15] error: Could not compile `rustc_trans`. |
||
} | ||
} | ||
|
||
// Create a dynamic library or executable | ||
// | ||
// This will invoke the system linker/cc to create the resulting file. This | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use a warning mechanism here? Or anything other than a println, basically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've used
println
for consistency here, because all arms of this match already useprintln
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we should only hit these on
--print