Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: introduce haiku x86_64 builder #44381

Merged
merged 4 commits into from
Sep 17, 2017
Merged

ci: introduce haiku x86_64 builder #44381

merged 4 commits into from
Sep 17, 2017

Conversation

jessicah
Copy link
Contributor

@jessicah jessicah commented Sep 7, 2017

No description provided.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@aidanhs
Copy link
Member

aidanhs commented Sep 7, 2017

Thanks for the PR! Would it be possible for you to move this new directory into the disabled folder to indicate that these aren't actually used by travis? We don't have capacity to add more builders at the moment.

@aidanhs aidanhs added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 7, 2017
@jessicah jessicah mentioned this pull request Sep 7, 2017
Closed
@alexcrichton
Copy link
Member

@jessicah any thoughts on @aidanhs's last comment?

@jessicah
Copy link
Contributor Author

Sorry, just haven't gotten around to updating, been busy with other Haiku work. Should have time this weekend.

Are there ever going to be plans to enable some of the disabled CI? It seems this story hasn't changed in a long time.

@alexcrichton
Copy link
Member

At this time we don't have a great story for turning on whole new builders, it ends up being quite a large investment on our end over time so there's more we need to work through to enable that.

@alexcrichton
Copy link
Member

Looks like tidy may be failing?

@aidanhs
Copy link
Member

aidanhs commented Sep 16, 2017

It appears our tidy checker is a bit overzealous, and detects any file marked as executable and without a .sh or .py extension to be a binary checked into git :(

I don't mind how you solve this (adding a .sh, chmod +x in the dockerfile) but travis won't let this pass as-is unfortunately.

@jessicah
Copy link
Contributor Author

It gets renamed in COPY in Dockerfile anyway, so adding .sh is fine.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Sep 16, 2017

📌 Commit 3443dd8 has been approved by alexcrichton

@alexcrichton
Copy link
Member

@bors: rollup

TimNN added a commit to TimNN/rust that referenced this pull request Sep 17, 2017
@TimNN
Rollup merge of rust-lang#44381 - jessicah:haiku-ci, r=alexcrichton
45e4306 
ci: introduce haiku x86_64 builder
@TimNN TimNN mentioned this pull request Sep 17, 2017
Closed
TimNN added a commit to TimNN/rust that referenced this pull request Sep 17, 2017
@TimNN
Rollup merge of rust-lang#44381 - jessicah:haiku-ci, r=alexcrichton
d378ee3 
ci: introduce haiku x86_64 builder
@TimNN TimNN mentioned this pull request Sep 17, 2017
Closed
TimNN added a commit to TimNN/rust that referenced this pull request Sep 17, 2017
@TimNN
Rollup merge of rust-lang#44381 - jessicah:haiku-ci, r=alexcrichton
2934588 
ci: introduce haiku x86_64 builder
@TimNN TimNN mentioned this pull request Sep 17, 2017
Merged
bors added a commit that referenced this pull request Sep 17, 2017
@bors
Auto merge of #44654 - TimNN:rollup, r=TimNN
1cdd689 
Rollup of 17 pull requests

- Successful merges: #44073, #44088, #44381, #44397, #44509, #44533, #44549, #44553, #44562, #44567, #44595, #44604, #44617, #44622, #44630, #44639, #44647
- Failed merges:
@bors bors merged commit 3443dd8 into rust-lang:master Sep 17, 2017
@workingjubilee workingjubilee added the O-haiku Target: Be extant; from mouldering old leaves; spring arrives again label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
O-haiku Target: Be extant; from mouldering old leaves; spring arrives again S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jessicah @rust-highfive @aidanhs @alexcrichton @bors @aturon @workingjubilee