Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --all flag to ./x.py clean #44694

Closed
wants to merge 2 commits into from
Closed

Add --all flag to ./x.py clean #44694

wants to merge 2 commits into from

Conversation

tommyip
Copy link
Contributor

@tommyip tommyip commented Sep 19, 2017 •
edited
Loading

This make clean removes the LLVM and download cache directory as well.

Fixes #44214.

r? @Mark-Simulacrum

@oli-obk
Copy link
Contributor

oli-obk commented Sep 19, 2017

Can we have a less nuclear option, too? After a rebase I frequently need to clean, but I really want to keep llvm.

@petrochenkov
Copy link
Contributor

petrochenkov commented Sep 19, 2017 •
edited
Loading

IIRC, the old build system had clean and clean-all removing everything-except-for-LLVM and everything, respectively.

@Mark-Simulacrum
Copy link
Member

@tommyip Would you be up to adding an additional subcommand to bootstrap (clean-all) that removes build and tmp and then leaving the existing clean as-is? I think that would satisfy all parties involved.

Such a step would need to be taken in src/bootstrap/flags, probably threading through into config and maybe a few other places -- I can provide more detailed instructions if you want them; let me know!

@arielb1 arielb1 added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 19, 2017
@tommyip
Copy link
Contributor Author

tommyip commented Sep 19, 2017

Sure I will have a go at that tomorrow.

@tommyip
Copy link
Contributor Author

tommyip commented Sep 20, 2017

Do we want clean --all or just clean-all?

@Mark-Simulacrum
Copy link
Member

I'm fine with either. Can you also update the documentation for clean? It won't take target/host etc anymore.

@tommyip
Add --all flag to ./x.py clean
2c78bb4 
This flag removes all build artifacts, including the LLVM build
directory.
@tommyip
Copy link
Contributor Author

tommyip commented Sep 20, 2017

Where is that documentation?

@tommyip tommyip changed the title Clean all build artifacts when running ./x.py clean Add --all flag to ./x.py clean Sep 20, 2017
@tommyip tommyip force-pushed the make_clean branch 2 times, most recently from 05aa486 to 779f3c1 Compare September 20, 2017 21:09
@tommyip
Copy link
Contributor Author

tommyip commented Sep 25, 2017

@Mark-Simulacrum This PR is ready for review.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 25, 2017
@Mark-Simulacrum
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 25, 2017

📌 Commit 09d90e5 has been approved by Mark-Simulacrum

@arielb1 arielb1 added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 26, 2017
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Sep 29, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#44694 - tommyip:make_clean, r=Mark-Simulacrum
6bc8ca0 
Add --all flag to ./x.py clean

This make `clean` removes the LLVM and download cache directory as well.

Fixes rust-lang#44214.

r? @Mark-Simulacrum
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Sep 29, 2017
Closed
bors added a commit that referenced this pull request Sep 30, 2017
@bors
Auto merge of #44936 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
c4cca3a 
Rollup of 15 pull requests

- Successful merges: #44124, #44287, #44320, #44694, #44708, #44794, #44797, #44824, #44836, #44840, #44845, #44854, #44889, #44900, #44903
- Failed merges:
@bors
Copy link
Contributor

bors commented Sep 30, 2017

☔ The latest upstream changes (presumably #44936) made this pull request unmergeable. Please resolve the merge conflicts.

@Mark-Simulacrum
Copy link
Member

Merged in #44936.

@tommyip tommyip deleted the make_clean branch September 30, 2017 15:04
@kennytm kennytm mentioned this pull request Dec 25, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tommyip @oli-obk @petrochenkov @Mark-Simulacrum @bors @arielb1