Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Foldable impl blocks #47894

Merged
merged 12 commits into from
Feb 28, 2018
Merged

rustdoc: Foldable impl blocks #47894

merged 12 commits into from
Feb 28, 2018

Commits on Jan 31, 2018

  1. rustdoc: Foldable impl blocks 

    Addresses rust-lang#40363, rust-lang#45720, rust-lang#24483, rust-lang#23986 and so on

* Expands and refactors collapseDocs and toggleAllDocs
* Adds [-] toggle to all impls (including inherent impl)
* Makes it hiding though main css file, not though element style

May need to be addressed:

* "[-]" and anchor link copier are overlaid a bit
* Inherent methods are also hidden by the global [-] toggle.
* Auto-collapsing "Iterator" and so on by default is not implemented yet
* Tested only shallowly and only in Chromiuim
* No tests. Are there tests for css/js part here?
* The new implementation may be a bit slower.
    @vi
    vi committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    73f52d3 View commit details
    Browse the repository at this point in the history

  2. rustdoc: Fix tidy errors found by travis

    @vi
    vi committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    7cd0280 View commit details
    Browse the repository at this point in the history

  3. rustdoc: Fix some minor issues per reviewer

    @vi
    vi committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    c904b1b View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2018

  1. rustdoc: Move collapse toggle to the left

    @vi
    vi committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    0885865 View commit details
    Browse the repository at this point in the history

  2. rustdoc: Auto-collapse all non-inherent impls

    @vi
    vi committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    a3acd10 View commit details
    Browse the repository at this point in the history

  3. rustdoc: Fix erroneous collapsing of second+ inherent impl.

    @vi
    vi committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    28efcfc View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2018

  1. Revert "rustdoc: Move collapse toggle to the left" 

    This reverts commit 0885865.
    @vi
    vi committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    bc277b2 View commit details
    Browse the repository at this point in the history

  2. rustdoc: Fix doc and impl collapsing on small screens

    @vi
    vi committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    71c4da8 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2018

  1. rustdoc: Remove visual overlap between § and [+]

    @vi
    vi committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    6442580 View commit details
    Browse the repository at this point in the history

  2. rustdoc: Fix position of collapse-toggle on small screens

    @vi
    vi committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    3c83596 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2018

  1. rustdoc: Reposition the § per GuillaumeGomez request

    @vi
    vi committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    bf03dd0 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2018

  1. rustdoc: On mobile: hide §, adjust [+] position

    @vi
    vi committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    df1b9a8 View commit details
    Browse the repository at this point in the history