Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve lint for type alias bounds #48909

Merged
merged 5 commits into from
Mar 23, 2018

Commits on Mar 10, 2018

  1. Split param-bounds-ignored into two, it was testing two independent t…

    …hings
    
    Also, tweak the test for ignored type aliases such that replacing the type alias
    by a newtype struct leads to a well-formed type definition, and errors when used
    the way the type alias is used.
    RalfJung committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    81130ed View commit details
    Browse the repository at this point in the history
  2. Rename ignored_generic_bounds -> type_alias_bounds

    First of all, the lint is specific for type aliases.  Second, it turns out the
    bounds are not entirely ignored but actually used when accessing associated
    types.  So change the wording of the lint, and adapt its name to reality.
    
    The lint has never been on stable or beta, so renaming is safe.
    RalfJung committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    562b44d View commit details
    Browse the repository at this point in the history
  3. type_alias_bounds lint: If the type alias uses an associated type wit…

    …hout "as", suggest to use the "as" form instead.
    
    This is necessary to get rid of the type bound, and hence silence the warning.
    RalfJung committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    0e6d40a View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2018

  1. wording nits

    RalfJung committed Mar 19, 2018
    Configuration menu
    Copy the full SHA
    37ff473 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c05d234 View commit details
    Browse the repository at this point in the history