Update RLS and Rustfmt #51677

nrc · 2018-06-21T09:15:31Z

r? @Mark-Simulacrum

rust-highfive · 2018-06-21T09:15:42Z

Warning

These commits modify submodules.

kennytm · 2018-06-21T10:27:03Z

@bors r+ p=84

bors · 2018-06-21T10:27:04Z

📌 Commit 04df56ca26995b2748a4247512c9994808ad7ad3 has been approved by kennytm

bors · 2018-06-21T11:09:32Z

⌛ Testing commit 04df56ca26995b2748a4247512c9994808ad7ad3 with merge 565cc733c08ef2dbc1006a469238ec63ed3cf9ea...

bors · 2018-06-21T11:28:10Z

💔 Test failed - status-travis

rust-highfive · 2018-06-21T11:28:12Z

The job x86_64-gnu-distcheck of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:15:33] 
#########                                                                 13.2%
######################################################################## 100.0%
[00:15:33] extracting /checkout/obj/build/tmp/distcheck/build/cache/2018-06-20/cargo-0.28.0-x86_64-unknown-linux-gnu.tar.gz
[00:15:33] error: failed to load source for a dependency on `cc`
[00:15:33] Caused by:
[00:15:33]   Unable to update registry `https:/rust-lang/crates.io-index`
[00:15:33] 
[00:15:33] Caused by:
[00:15:33] Caused by:
[00:15:33]   failed to update replaced source registry `https:/rust-lang/crates.io-index`
[00:15:33] 
[00:15:33] Caused by:
[00:15:33]   failed to parse manifest at `/checkout/obj/build/tmp/distcheck/src/vendor/clippy_lints/Cargo.toml`
[00:15:33] 
[00:15:33] Caused by:
[00:15:33]   the cargo feature `edition` requires a nightly version of Cargo, but this is the `stable` channel
[00:15:33] failed to run: /checkout/obj/build/tmp/distcheck/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/obj/build/tmp/distcheck/src/bootstrap/Cargo.toml --locked --frozen
[00:15:33] Build completed unsuccessfully in 0:00:14
[00:15:33] Makefile:58: recipe for target 'check' failed
[00:15:33] make: *** [check] Error 1
[00:15:33] 
[00:15:33] 
[00:15:33] command did not execute successfully: "make" "check"
[00:15:33] 
[00:15:33] 
[00:15:33] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test distcheck
[00:15:33] Build completed unsuccessfully in 0:11:56
---
travis_time:end:0f17f440:start=1529580411097826901,finish=1529580411104056288,duration=6229387
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0a377784
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0a2e6d0f
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kennytm · 2018-06-21T12:48:00Z

src/Cargo.lock

@@ -348,7 +348,7 @@ dependencies = [

 [[package]]
 name = "clippy_lints"
-version = "0.0.205"


Could we keep clippy_lints at version 0.0.206 or below? Otherwise we'll be blocked by the 1.29.0 compiler bump (similar to #51122).

If we must upgrade clippy_lints I'd prefer we close this PR and update everything in the 1.29.0 version bump.

Neither 0.0.205 or 0.0.207 clippy version is buildable with master so rls could temporary disable dependency. I think it would be simplest solution for now.
Another solution would be disabling edition=2018 in clippy and fixing incompatible code, then releasing new version.

Given that we'd need to make and keep a branch around forever, let's just wait till the 1.29 bump (it's only a few days, right?)

kennytm · 2018-06-21T18:46:45Z

@bors r-

Requeued again, sorry the infra is very broken this week.

bors · 2018-06-24T00:40:54Z

☔ The latest upstream changes (presumably #51739) made this pull request unmergeable. Please resolve the merge conflicts.

kennytm · 2018-07-01T10:06:52Z

#51717 has been merged.

nrc · 2018-07-01T22:08:43Z

r? @kennytm

bors · 2018-07-06T00:40:00Z

☔ The latest upstream changes (presumably #51732) made this pull request unmergeable. Please resolve the merge conflicts.

nrc · 2018-07-06T01:44:16Z

@bors: r=kennytm

bors · 2018-07-06T01:44:17Z

📌 Commit 3df836162afdf0a2a5b3a9c53ba5869d1aebad64 has been approved by kennytm

rust-highfive · 2018-07-06T03:23:53Z

The job x86_64-gnu-tools of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[01:01:10]    Compiling termcolor v0.3.6
[01:01:13]    Compiling fnv v1.0.6
[01:01:13]    Compiling hex v0.3.2
[01:01:13]    Compiling crossbeam v0.3.2
[01:01:14]    Compiling rustfmt-nightly v0.8.2 (https:/rust-lang-nursery/rustfmt?rev=5e5992517d3591e2708d4ca6b155dfcbdf3344b9#5e599251)
[01:01:17]    Compiling diff v0.1.11
[01:01:17]    Compiling rls v0.129.0 (file:///checkout/src/tools/rls)
[01:01:17]    Compiling getopts v0.2.17
[01:01:20]    Compiling glob v0.2.11
---
[01:19:08] test actions::test::test_find_word_at_pos ... ok
[01:19:08] test build::cargo::test::test_dedup_flags ... ok
[01:19:08] test cmd::url_workaround_unc_canonicals ... ok
[01:19:08] test config::clippy_preference_from_str ... ok
[01:19:08] test server::io::tests::read_message_fails_on_empty_input ... ok
[01:19:08] test server::io::tests::read_message_fails_when_content_is_not_valid_utf8 ... ok
[01:19:08] test server::io::tests::read_message_fails_when_content_type_is_invalid ... ok
[01:19:08] test server::io::tests::read_message_fails_when_header_line_is_invalid ... ok
[01:19:08] test server::io::tests::read_message_fails_when_input_contains_only_header ... ok
[01:19:08] test server::io::tests::read_message_fails_when_length_is_too_large_integer ... ok
[01:19:08] test server::io::tests::read_message_fails_when_length_header_is_missing ... ok
[01:19:08] test server::io::tests::read_message_fails_when_length_is_not_numeric ... ok
[01:19:08] test server::io::tests::read_message_returns_message_from_input_with_unknown_headers ... ok
[01:19:08] test server::io::tests::read_message_returns_message_from_input_with_multiple_headers ... ok
[01:19:08] test server::io::tests::read_message_returns_message_from_valid_lsr_input ... ok
[01:19:08] test server::message::test::raw_message_parses_valid_jsonrpc_request_with_numeric_id ... ok
[01:19:08] test server::message::test::deserialize_message_empty_params ... ok
[01:19:08] test server::message::test::raw_message_with_string_id_parses_into_request ... ok
[01:19:08] test server::message::test::serialize_message_empty_params ... ok
---
[01:19:20] 
[01:19:20] running 2 tests
[01:19:20] expect_messages:
[01:19:20]   results: [
[01:19:20]     "{\"jsonrpc\":\"2.0\",\"id\":0,\"result\":{\"capabilities\":{\"textDocumentSync\":2,\"hoverProvider\":true,\"completionProvider\":{\"resolveProvider\":true,\"triggerCharacters\":[\".\",\":\"]},\"definitionProvider\":true,\"referencesProvider\":true,\"documentHighlightProvider\":true,\"documentSymbolProvider\":true,\"workspaceSymbolProvider\":true,\"codeActionProvider\":true,\"codeLensProvider\":{\"resolveProvider\":false},\"documentFormattingProvider\":true,\"documentRangeFormattingProvider\":false,\"renameProvider\":true,\"executeCommandProvider\":{\"commands\":[\"rls.applySuggestion-29681\",\"rls.deglobImports-29681\"]}}}}",
[01:19:20]     "{\"jsonrpc\":\"2.0\",\"method\":\"window/progress\",\"params\":{\"id\":\"progress_1\",\"message\":\"foo\",\"title\":\"Building\"}}",
[01:19:20]     "{\"jsonrpc\":\"2.0\",\"method\":\"window/progress\",\"params\":{\"id\":\"progress_1\",\"message\":\"foo\",\"title\":\"Building\"}}",
[01:19:20]     "{\"jsonrpc\":\"2.0\",\"method\":\"window/progress\",\"params\":{\"done\":true,\"id\":\"progress_1\",\"title\":\"Building\"}}",
[01:19:20]     "{\"jsonrpc\":\"2.0\",\"method\":\"window/progress\",\"params\":{\"id\":\"progress_0\",\"title\":\"Indexing\"}}",
---
[01:19:20] ]
[01:19:20] test cmd_test_infer_bin ... ok
[01:19:21] expect_messages:
[01:19:21]   results: [
[01:19:21]     "{\"jsonrpc\":\"2.0\",\"id\":0,\"result\":{\"capabilities\":{\"textDocumentSync\":2,\"hoverProvider\":true,\"completionProvider\":{\"resolveProvider\":true,\"triggerCharacters\":[\".\",\":\"]},\"definitionProvider\":true,\"referencesProvider\":true,\"documentHighlightProvider\":true,\"documentSymbolProvider\":true,\"workspaceSymbolProvider\":true,\"codeActionProvider\":true,\"codeLensProvider\":{\"resolveProvider\":false},\"documentFormattingProvider\":true,\"documentRangeFormattingProvider\":false,\"renameProvider\":true,\"executeCommandProvider\":{\"commands\":[\"rls.applySuggestion-29682\",\"rls.deglobImports-29682\"]}}}}",
[01:19:21]     "{\"jsonrpc\":\"2.0\",\"method\":\"window/progress\",\"params\":{\"id\":\"progress_1\",\"message\":\"member_lib\",\"title\":\"Building\"}}",
[01:19:21]     "{\"jsonrpc\":\"2.0\",\"method\":\"window/progress\",\"params\":{\"id\":\"progress_1\",\"message\":\"member_lib\",\"title\":\"Building\"}}",
[01:19:21]     "{\"jsonrpc\":\"2.0\",\"method\":\"window/progress\",\"params\":{\"id\":\"progress_1\",\"message\":\"member_bin\",\"title\":\"Building\"}}",
[01:19:21]     "{\"jsonrpc\":\"2.0\",\"method\":\"window/progress\",\"params\":{\"id\":\"progress_1\",\"message\":\"member_bin\",\"title\":\"Building\"}}",
---
travis_time:end:03946e21:start=1530846976208640879,finish=1530846976215227456,duration=6586577
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:1ae438d8
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0a5de5af
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2018-07-06T03:37:34Z

⌛ Testing commit 3df836162afdf0a2a5b3a9c53ba5869d1aebad64 with merge 0825b84ad4f72bcc0d60e9e5cb3aac41b250d477...

bors · 2018-07-06T03:54:15Z

💔 Test failed - status-travis

rust-highfive · 2018-07-06T03:54:16Z

The job x86_64-gnu-distcheck of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:13:53] * wrapping_iter_arith              lib      stable       1.14.0  
[00:13:53] * wrapping_neg                     lib      stable       1.10.0  
[00:13:53] * wrapping_next_power_of_two       lib      unstable     None    
[00:13:53] * wrapping_ref                     lib      stable       1.14.0  
[00:13:53] invalid license Apache-2.0 in /checkout/obj/build/tmp/distcheck/src/vendor/ordslice/Cargo.toml
[00:13:53] some tidy checks failed
[00:13:53] 
[00:13:53] 
[00:13:53] command did not execute successfully: "/checkout/obj/build/tmp/distcheck/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/obj/build/tmp/distcheck/src" "/checkout/obj/build/tmp/distcheck/build/x86_64-unknown-linux-gnu/stage0/bin/cargo"
[00:13:53] 
[00:13:53] 
[00:13:53] failed to run: /checkout/obj/build/tmp/distcheck/build/bootstrap/debug/bootstrap test
[00:13:53] Build completed unsuccessfully in 0:02:03
[00:13:53] Build completed unsuccessfully in 0:02:03
[00:13:53] Makefile:58: recipe for target 'check' failed
[00:13:53] make: *** [check] Error 1
[00:13:53] 
[00:13:53] 
[00:13:53] command did not execute successfully: "make" "check"
[00:13:53] 
[00:13:53] 
[00:13:53] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test distcheck
[00:13:53] Build completed unsuccessfully in 0:11:14
---
travis_time:end:021cc504:start=1530849230269246487,finish=1530849230275739982,duration=6493495
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:123d3b75
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:14a9a500
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-07-06T03:54:21Z

The job x86_64-gnu-distcheck of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:13:53] * wrapping_iter_arith              lib      stable       1.14.0  
[00:13:53] * wrapping_neg                     lib      stable       1.10.0  
[00:13:53] * wrapping_next_power_of_two       lib      unstable     None    
[00:13:53] * wrapping_ref                     lib      stable       1.14.0  
[00:13:53] invalid license Apache-2.0 in /checkout/obj/build/tmp/distcheck/src/vendor/ordslice/Cargo.toml
[00:13:53] some tidy checks failed
[00:13:53] 
[00:13:53] 
[00:13:53] command did not execute successfully: "/checkout/obj/build/tmp/distcheck/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/obj/build/tmp/distcheck/src" "/checkout/obj/build/tmp/distcheck/build/x86_64-unknown-linux-gnu/stage0/bin/cargo"
[00:13:53] 
[00:13:53] 
[00:13:53] failed to run: /checkout/obj/build/tmp/distcheck/build/bootstrap/debug/bootstrap test
[00:13:53] Build completed unsuccessfully in 0:02:03
[00:13:53] Build completed unsuccessfully in 0:02:03
[00:13:53] Makefile:58: recipe for target 'check' failed
[00:13:53] make: *** [check] Error 1
[00:13:53] 
[00:13:53] 
[00:13:53] command did not execute successfully: "make" "check"
[00:13:53] 
[00:13:53] 
[00:13:53] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test distcheck
[00:13:53] Build completed unsuccessfully in 0:11:14
---
travis_time:end:021cc504:start=1530849230269246487,finish=1530849230275739982,duration=6493495
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:123d3b75
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:14a9a500
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kennytm · 2018-07-06T04:59:17Z

That ordslice fix disappeared?

[00:13:53] invalid license Apache-2.0 in /checkout/obj/build/tmp/distcheck/src/vendor/ordslice/Cargo.toml

nrc · 2018-07-06T08:59:22Z

@bors: r=kennytm

Can someone sacrifice a goat or something to get this to land?

bors · 2018-07-06T08:59:22Z

📌 Commit 7717705 has been approved by kennytm

rust-highfive · 2018-07-06T10:29:18Z

The job x86_64-gnu-tools of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:58:37]    Compiling strsim v0.7.0
[00:58:40]    Compiling termcolor v0.3.6
[00:58:40]    Compiling hex v0.3.2
[00:58:40]    Compiling crossbeam v0.3.2
[00:58:43]    Compiling rustfmt-nightly v0.8.2 (https:/rust-lang-nursery/rustfmt?rev=5e5992517d3591e2708d4ca6b155dfcbdf3344b9#5e599251)
[00:58:45]    Compiling home v0.3.2
[00:58:47]    Compiling shell-escape v0.1.4
[00:58:47]    Compiling futures v0.1.21
[00:58:47]    Compiling glob v0.2.11
---
[01:16:08] test actions::diagnostics::diagnostic_suggestion_test::suggest_use_when_cannot_find_type ... ok
[01:16:08] test actions::requests::test::test_sort_deglob_str ... ok
[01:16:08] test config::clippy_preference_from_str ... ok
[01:16:08] test build::cargo::test::test_dedup_flags ... ok
[01:16:08] test server::io::tests::read_message_fails_on_empty_input ... ok
[01:16:08] test cmd::url_workaround_unc_canonicals ... ok
[01:16:08] test server::io::tests::read_message_fails_when_content_is_not_valid_utf8 ... ok
[01:16:08] test server::io::tests::read_message_fails_when_content_type_is_invalid ... ok
[01:16:08] test server::io::tests::read_message_fails_when_length_is_not_numeric ... ok
[01:16:08] test server::io::tests::read_message_fails_when_header_line_is_invalid ... ok
[01:16:08] test server::io::tests::read_message_fails_when_length_is_too_large_integer ... ok
[01:16:08] test server::io::tests::read_message_fails_when_input_contains_only_header ... ok
[01:16:08] test server::io::tests::read_message_fails_when_length_header_is_missing ... ok
[01:16:08] test server::io::tests::read_message_returns_message_from_input_with_multiple_headers ... ok
[01:16:08] test server::io::tests::read_message_returns_message_from_input_with_unknown_headers ... ok
[01:16:08] test server::io::tests::read_message_returns_message_from_valid_lsr_input ... ok
[01:16:08] test server::message::test::raw_message_parses_valid_jsonrpc_request_with_numeric_id ... ok
[01:16:08] test server::message::test::raw_message_parses_valid_jsonrpc_request_with_string_id ... ok
[01:16:08] test server::message::test::raw_message_with_string_id_parses_into_request ... ok
[01:16:08] test server::message::test::serialize_message_empty_params ... ok
---
[01:16:19] 
[01:16:19] running 2 tests
[01:16:19] expect_messages:
[01:16:19]   results: [
[01:16:19]     "{\"jsonrpc\":\"2.0\",\"id\":0,\"result\":{\"capabilities\":{\"textDocumentSync\":2,\"hoverProvider\":true,\"completionProvider\":{\"resolveProvider\":true,\"triggerCharacters\":[\".\",\":\"]},\"definitionProvider\":true,\"referencesProvider\":true,\"documentHighlightProvider\":true,\"documentSymbolProvider\":true,\"workspaceSymbolProvider\":true,\"codeActionProvider\":true,\"codeLensProvider\":{\"resolveProvider\":false},\"documentFormattingProvider\":true,\"documentRangeFormattingProvider\":false,\"renameProvider\":true,\"executeCommandProvider\":{\"commands\":[\"rls.applySuggestion-29685\",\"rls.deglobImports-29685\"]}}}}",
[01:16:19]     "{\"jsonrpc\":\"2.0\",\"method\":\"window/progress\",\"params\":{\"id\":\"progress_1\",\"message\":\"foo\",\"title\":\"Building\"}}",
[01:16:19]     "{\"jsonrpc\":\"2.0\",\"method\":\"window/progress\",\"params\":{\"id\":\"progress_1\",\"message\":\"foo\",\"title\":\"Building\"}}",
[01:16:19]     "{\"jsonrpc\":\"2.0\",\"method\":\"window/progress\",\"params\":{\"done\":true,\"id\":\"progress_1\",\"title\":\"Building\"}}",
[01:16:19]     "{\"jsonrpc\":\"2.0\",\"method\":\"window/progress\",\"params\":{\"id\":\"progress_0\",\"title\":\"Indexing\"}}",
---
[01:16:19] ]
[01:16:19] test cmd_test_infer_bin ... ok
[01:16:20] expect_messages:
[01:16:20]   results: [
[01:16:20]     "{\"jsonrpc\":\"2.0\",\"id\":0,\"result\":{\"capabilities\":{\"textDocumentSync\":2,\"hoverProvider\":true,\"completionProvider\":{\"resolveProvider\":true,\"triggerCharacters\":[\".\",\":\"]},\"definitionProvider\":true,\"referencesProvider\":true,\"documentHighlightProvider\":true,\"documentSymbolProvider\":true,\"workspaceSymbolProvider\":true,\"codeActionProvider\":true,\"codeLensProvider\":{\"resolveProvider\":false},\"documentFormattingProvider\":true,\"documentRangeFormattingProvider\":false,\"renameProvider\":true,\"executeCommandProvider\":{\"commands\":[\"rls.applySuggestion-29686\",\"rls.deglobImports-29686\"]}}}}",
[01:16:20]     "{\"jsonrpc\":\"2.0\",\"method\":\"window/progress\",\"params\":{\"id\":\"progress_1\",\"message\":\"member_lib\",\"title\":\"Building\"}}",
[01:16:20]     "{\"jsonrpc\":\"2.0\",\"method\":\"window/progress\",\"params\":{\"id\":\"progress_1\",\"message\":\"member_lib\",\"title\":\"Building\"}}",
[01:16:20]     "{\"jsonrpc\":\"2.0\",\"method\":\"window/progress\",\"params\":{\"id\":\"progress_1\",\"message\":\"member_bin\",\"title\":\"Building\"}}",
[01:16:20]     "{\"jsonrpc\":\"2.0\",\"method\":\"window/progress\",\"params\":{\"id\":\"progress_1\",\"message\":\"member_bin\",\"title\":\"Building\"}}",
---
travis_time:end:0184384a:start=1530872954348914889,finish=1530872954354198101,duration=5283212
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:03870039
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0181780e
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2018-07-06T10:55:09Z

⌛ Testing commit 7717705 with merge ded86cc...

@Mark-Simulacrum

Update RLS and Rustfmt r? @Mark-Simulacrum

bors · 2018-07-06T12:54:39Z

☀️ Test successful - status-appveyor, status-travis
Approved by: kennytm
Pushing ded86cc to master...

rust-highfive · 2018-07-06T12:55:58Z

📣 Toolstate changed by #51677!

Tested on commit ded86cc.
Direct link to PR: #51677

🎉 rls on windows: build-fail → test-pass.
🎉 rls on linux: build-fail → test-pass.
🎉 rustfmt on windows: build-fail → test-pass.
🎉 rustfmt on linux: build-fail → test-pass.

Tested on commit rust-lang/rust@ded86cc. Direct link to PR: <rust-lang/rust#51677> 🎉 rls on windows: build-fail → test-pass. 🎉 rls on linux: build-fail → test-pass. 🎉 rustfmt on windows: build-fail → test-pass. 🎉 rustfmt on linux: build-fail → test-pass.

rust-highfive assigned Mark-Simulacrum Jun 21, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 21, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 21, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 21, 2018

rust-lang deleted a comment from rust-highfive Jun 21, 2018

kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 21, 2018

kennytm reviewed Jun 21, 2018

View reviewed changes

kennytm mentioned this pull request Jun 23, 2018

Update rustfmt submodule #51739

Merged

kennytm added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 23, 2018

kennytm mentioned this pull request Jun 25, 2018

Bootstrap from 1.28.0 beta #51717

Merged

mati865 mentioned this pull request Jun 30, 2018

Did you mean to block nightlies on clippy? #51122

Merged

kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels Jul 1, 2018

mati865 mentioned this pull request Jul 1, 2018

Update clippy via commit hashes instead of version numbers rust-lang/rls#893

Closed

nrc force-pushed the update branch from 04df56c to 239a83e Compare July 1, 2018 22:08

nrc force-pushed the update branch from 3b07618 to 3df8361 Compare July 6, 2018 01:43

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 6, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 6, 2018

kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 6, 2018

Update RLS, Rustfmt, Cargo, and Clippy

7717705

nrc force-pushed the update branch from 3df8361 to 7717705 Compare July 6, 2018 08:58

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 6, 2018

bors added a commit that referenced this pull request Jul 6, 2018

Auto merge of #51677 - nrc:update, r=kennytm

ded86cc

Update RLS and Rustfmt r? @Mark-Simulacrum

bors merged commit 7717705 into rust-lang:master Jul 6, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update RLS and Rustfmt #51677

Update RLS and Rustfmt #51677

nrc commented Jun 21, 2018

rust-highfive commented Jun 21, 2018

kennytm commented Jun 21, 2018

bors commented Jun 21, 2018

bors commented Jun 21, 2018

bors commented Jun 21, 2018

rust-highfive commented Jun 21, 2018

kennytm Jun 21, 2018 •

edited

Loading

mati865 Jun 21, 2018

nrc Jun 22, 2018

kennytm commented Jun 21, 2018

bors commented Jun 24, 2018

kennytm commented Jul 1, 2018

nrc commented Jul 1, 2018

bors commented Jul 6, 2018

nrc commented Jul 6, 2018

bors commented Jul 6, 2018

rust-highfive commented Jul 6, 2018

bors commented Jul 6, 2018

bors commented Jul 6, 2018

rust-highfive commented Jul 6, 2018

rust-highfive commented Jul 6, 2018

kennytm commented Jul 6, 2018

nrc commented Jul 6, 2018

bors commented Jul 6, 2018

rust-highfive commented Jul 6, 2018

bors commented Jul 6, 2018

bors commented Jul 6, 2018

rust-highfive commented Jul 6, 2018

Update RLS and Rustfmt #51677

Update RLS and Rustfmt #51677

Conversation

nrc commented Jun 21, 2018

rust-highfive commented Jun 21, 2018

kennytm commented Jun 21, 2018

bors commented Jun 21, 2018

bors commented Jun 21, 2018

bors commented Jun 21, 2018

rust-highfive commented Jun 21, 2018

kennytm Jun 21, 2018 • edited Loading

Choose a reason for hiding this comment

mati865 Jun 21, 2018

Choose a reason for hiding this comment

nrc Jun 22, 2018

Choose a reason for hiding this comment

kennytm commented Jun 21, 2018

bors commented Jun 24, 2018

kennytm commented Jul 1, 2018

nrc commented Jul 1, 2018

bors commented Jul 6, 2018

nrc commented Jul 6, 2018

bors commented Jul 6, 2018

rust-highfive commented Jul 6, 2018

bors commented Jul 6, 2018

bors commented Jul 6, 2018

rust-highfive commented Jul 6, 2018

rust-highfive commented Jul 6, 2018

kennytm commented Jul 6, 2018

nrc commented Jul 6, 2018

bors commented Jul 6, 2018

rust-highfive commented Jul 6, 2018

bors commented Jul 6, 2018

bors commented Jul 6, 2018

rust-highfive commented Jul 6, 2018

kennytm Jun 21, 2018 •

edited

Loading