Fixes #53119. #53186
Merged
Fixes #53119. #53186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
mikhail-m1
commented
Aug 8, 2018
| // `ClosureOutlivesRequirement`. | ||
| let r_scc = self.constraint_sccs.scc(*lower_bound); | ||
| for ur in self.scc_values.universal_regions_outlived_by(r_scc) { | ||
| let non_local_ub = self.universal_region_relations.non_local_upper_bound(ur); |
There was a problem hiding this comment.
I cannot use non_local_universal_upper_bound because it returns 'static for '_#5r from your comment in the issue
nikomatsakis
approved these changes
Aug 8, 2018
| !self | ||
| // For each region outlived by lower_bound find a non-local, | ||
| // universal region (it may be the same region) and add it to | ||
| // `ClosureOutlivesRequirement`. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
@bors r+ p=1 This is a RC blocker for NLL. |
|
📌 Commit e5f32ef has been approved by |
bors
added
S-waiting-on-bors
cramertj
added a commit
to cramertj/rust
that referenced
this pull request
Aug 8, 2018
Fixes rust-lang#53119. Fixes rust-lang#53119. I minimized sample little bit more, but I checked the sample from issue too. r? @nikomatsakis
bors
added a commit
that referenced
this pull request
Aug 8, 2018
Fixes #53119. Fixes #53119. I minimized sample little bit more, but I checked the sample from issue too. r? @nikomatsakis
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53119.
I minimized sample little bit more, but I checked the sample from issue too.
r? @nikomatsakis