Do not emit E0277 on incorrect tuple destructured binding #53371
Conversation
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
src/librustc_typeck/check/_match.rs
Outdated
| for (_, elem) in elements.iter().enumerate_and_adjust(max_len, ddpos) { | ||
| self.check_pat_walk(elem, &tcx.types.err, def_bm, true); | ||
| } | ||
| tcx.mk_ty(ty::TyTuple(element_tys)) |
There was a problem hiding this comment.
Can this use tcx.mk_tup or something instead? It seems a bit too complex.
There was a problem hiding this comment.
Fair enough. Will change.
There was a problem hiding this comment.
I'm just not sure how extensive the effects of enumerate_and_adjust and check_pat_walk are.
I'll try to get a compile with simplified logic, but will keep it as a separate commit in case it causes uncaught regressions.
src/librustc/ty/relate.rs
Outdated
| let region_bound = relation.with_cause( | ||
| Cause::ExistentialRegionBound, | ||
| |relation| relation.relate_with_variance(ty::Contravariant, a_region, b_region), | ||
| )?; |
There was a problem hiding this comment.
Is this just a drive-by formatting change? I'd prefer if it wasn't included, it feels confusing.
There was a problem hiding this comment.
Yes. If I recall correctly I was looking if I needed to modify that file while exploring for a solution and left that small cleanup in because it was small enough, but I can revert it.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Ping from triage @eddyb / @rust-lang/compiler: This PR requires your review. |
|
Please do not assign me diagnostics PRs. r? @nikomatsakis |
|
@bors r=nikomatsakis rollup |
|
📌 Commit 63cd81c has been approved by |
bors
added
S-waiting-on-bors
Do not emit E0277 on incorrect tuple destructured binding Fix rust-lang#50333.
Rollup of 11 pull requests Successful merges: - #53371 (Do not emit E0277 on incorrect tuple destructured binding) - #53829 (Add rustc SHA to released DWARF debuginfo) - #53950 (Allow for opting out of ThinLTO and clean up LTO related cli flag handling.) - #53976 (Replace unwrap calls in example by expect) - #54070 (Add Error::description soft-deprecation to RELEASES) - #54076 (miri loop detector hashing) - #54119 (Add some unit tests for find_best_match_for_name) - #54147 (Add a test that tries to modify static memory at compile-time) - #54150 (Updated 1.29 release notes with --document-private-items flag) - #54163 (Update stage 0 to latest beta) - #54170 (COMPILER_TESTS.md has been moved)
Fix #50333.