Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reduce E0161 to a warning in NLL migrate mode #53575

Merged
merged 2 commits into from
Sep 6, 2018

Conversation

matthewjasper
Copy link
Contributor

This error has been on stable for a while, and allowing such code cause the compile to later ICE (since we can't codegen it). Errors box UNSIZED EXPR with unsized locals because it's not compatible with the current evaluation order (create the box before evaluating the expressions).

cc #53469 (fixes the ICE in this case)
cc @qnighy

@rust-highfive
Copy link
Collaborator

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 21, 2018
@bors
Copy link
Contributor

bors commented Aug 22, 2018

☔ The latest upstream changes (presumably #53581) made this pull request unmergeable. Please resolve the merge conflicts.

* Sized checking in MIR should be a hard error in all borrowck modes
* box operands should be an error even with unsized locals
Update another test that broke due to E0161 no longer being buffered
@pietroalbini
Copy link
Member

Ping from triage @pnkfelix! This PR needs your review.

@memoryruins memoryruins added the A-NLL Area: Non-lexical lifetimes (NLL) label Aug 28, 2018
@TimNN
Copy link
Contributor

TimNN commented Sep 4, 2018

Ping from triage @pnkfelix / @rust-lang/compiler: This PR requires your review.

@estebank
Copy link
Contributor

estebank commented Sep 5, 2018

@bors r+
cc @nikomatsakis

@bors
Copy link
Contributor

bors commented Sep 5, 2018

📌 Commit cd92da8 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 5, 2018
@bors
Copy link
Contributor

bors commented Sep 5, 2018

⌛ Testing commit cd92da8 with merge dd89cb727553577e9917c27788ce8d907c49be40...

@bors
Copy link
Contributor

bors commented Sep 5, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 5, 2018
@matthewjasper
Copy link
Contributor Author

@bors: r=estebank

@bors
Copy link
Contributor

bors commented Sep 6, 2018

@matthewjasper: 🔑 Insufficient privileges: Not in reviewers

@estebank
Copy link
Contributor

estebank commented Sep 6, 2018

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2018
@bors
Copy link
Contributor

bors commented Sep 6, 2018

⌛ Testing commit cd92da8 with merge a8c11d2...

bors added a commit that referenced this pull request Sep 6, 2018
Don't reduce E0161 to a warning in NLL migrate mode

This error has been on stable for a while, and allowing such code cause the compile to later ICE (since we can't codegen it). Errors `box UNSIZED EXPR` with unsized locals because it's not compatible with the current evaluation order (create the box before evaluating the expressions).

cc #53469 (fixes the ICE in this case)
cc @qnighy
@bors
Copy link
Contributor

bors commented Sep 6, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: estebank
Pushing a8c11d2 to master...

@bors bors merged commit cd92da8 into rust-lang:master Sep 6, 2018
@bors bors mentioned this pull request Sep 6, 2018
3 tasks
@matthewjasper matthewjasper deleted the unsized-is-an-error branch September 8, 2018 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-NLL Area: Non-lexical lifetimes (NLL) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants