Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't rerun MIR passes when inlining #55244

Merged
merged 4 commits into from
Oct 28, 2018
Merged

Commits on Oct 23, 2018

  1. Don't rerun Mir passes when inlining

    When inlining a function using the Mir inliner, we shouldn't rerun the
    various Mir passes on it because the Mir has already been lowered and
    that wil break various early Mir passes.
    
    The issue in rust-lang#50411 is that we've inlined a function with promotions
    whose Mir has already been lowered. The promotions are then copied into
    the local function and we begin to run passes on their lowered Mir
    which causes the ICE.
    
    Fixes rust-lang#50411
    nikomatsakis authored and wesleywiser committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    37e1d29 View commit details
    Browse the repository at this point in the history
  2. Remove the suite_index parameter of the run_passes!() macro

    This can be obtained via the `$mir_phase` value.
    wesleywiser committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    895a4b2 View commit details
    Browse the repository at this point in the history
  3. Replace the run_passes! macro with a regular function

    As suggested in the feedback for rust-lang#55244.
    
    When I replaced the macro with a function, rustc started complaining
    that there were two unused functions so I also removed those.
    wesleywiser committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    c535147 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2018

  1. Fix CR feedback

    wesleywiser committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    4655866 View commit details
    Browse the repository at this point in the history