Allocate HIR on an arena #57173

Zoxc · 2018-12-28T16:43:30Z

Blocked on ~~#56864~~ ~~#59205~~ (closed unmerged)

rust-highfive · 2018-12-28T16:43:33Z

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

Zoxc · 2019-01-11T06:54:03Z

@bors try

bors · 2019-01-11T06:54:17Z

⌛ Trying commit 274b927 with merge 6e789d4...

[WIP] Allocate HIR on an arena Blocked on #56864

bors · 2019-01-11T09:05:51Z

☀️ Test successful - checks-travis
State: approved= try=True

Zoxc · 2019-01-11T09:51:30Z

@rust-timer build 6e789d4

rust-timer · 2019-01-11T09:51:32Z

Success: Queued 6e789d4 with parent 729d3f0, comparison URL.

rust-timer · 2019-01-11T11:18:45Z

Finished benchmarking try commit 6e789d4

estebank · 2019-03-09T01:42:08Z

src/librustc/cfg/construct.rs

- ) -> CFGIndex {
+ fn pats_all<'b, 'h: 'b, I: Iterator<Item=&'b P<'h, hir::Pat<'h>>>>(&mut self,
+ pats: I,
+ pred: CFGIndex) -> CFGIndex {


Intrigued by this change, the previous formatting was correct.

There are a few of these changes were formatting is reverted to the formatting at the time I created the commit. Totally could use some rustfmt help.

Could you clean the indenting back to what it was here?

estebank · 2019-03-09T01:44:52Z

src/librustc/hir/ptr.rs

+use serialize::{Encodable, Decodable, Encoder, Decoder};
+
+use rustc_data_structures::stable_hasher::{StableHasher, StableHasherResult,
+ HashStable};


src/librustc_resolve/resolve_imports.rs

bors · 2019-05-05T15:38:30Z

☔ The latest upstream changes (presumably #60544) made this pull request unmergeable. Please resolve the merge conflicts.

mark-i-m · 2019-06-07T16:56:17Z

This is no longer blocked, right?

Zoxc · 2019-06-07T17:10:54Z

Still blocked on #59205

eddyb · 2019-06-12T11:27:31Z

src/librustc/hir/lowering.rs

-pub struct LoweringContext<'a> {
+macro_rules! p {
+ ($this:expr, $e:expr) => ({
+ P::alloc($this.arena, $e)


I wonder if this could be just $this.alloc($e) and maybe then we wouldn't need a macro?
Then again, I think the macro allows nested allocations (e.g. p!(self, Foo(p!(self, Bar(...))))) without borrow conflicts, since $this.arena can just be copied.

rust-highfive · 2019-06-14T21:48:05Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:05327421:start=1560548418041373799,finish=1560548420639481334,duration=2598107535
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---

[00:04:34] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:04:34] tidy error: /checkout/src/librustc_mir/build/mod.rs:518: line longer than 100 chars
[00:04:34] tidy error: /checkout/src/librustc/hir/lowering.rs:3337: line longer than 100 chars
[00:04:39] some tidy checks failed
[00:04:39] 
[00:04:39] 
[00:04:39] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:39] 
[00:04:39] 
[00:04:39] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:39] Build completed unsuccessfully in 0:01:11
---
travis_time:end:1e99c5c3:start=1560548711251426117,finish=1560548711256224005,duration=4797888
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:12b72805
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:1d43b7e8
travis_time:start:1d43b7e8
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:057bc055
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2019-06-15T06:33:57Z

☔ The latest upstream changes (presumably #61825) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2019-06-15T21:16:07Z

☔ The latest upstream changes (presumably #61868) made this pull request unmergeable. Please resolve the merge conflicts.

Dylan-DPC-zz · 2019-12-25T09:53:59Z

The PR that this was blocked on was closed so unblocking it

rust-highfive assigned estebank Dec 28, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 28, 2018