Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize refcell_replace_swap feature #59581

Merged
merged 2 commits into from
Mar 31, 2019
Merged

Stabilize refcell_replace_swap feature #59581

merged 2 commits into from
Mar 31, 2019

Conversation

jmcomets
Copy link
Contributor

Please be kind, this is my first time contributing. 😄

I noticed #43570 only needs stabilizing (and I need it for a side project I'm working on), so I followed the guide to move things forward.

I'm happy to amend things if needed, let me know!

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 31, 2019
Centril
Centril suggested changes Mar 31, 2019
View reviewed changes
src/libcore/cell.rs Show resolved Hide resolved
src/libsyntax/feature_gate.rs Outdated Show resolved Hide resolved
@Centril
Copy link
Contributor

Centril commented Mar 31, 2019

Hi! Thanks for you contribution. :)

r? @Centril

r=me with changes requested above and green travis :)

@rust-highfive rust-highfive assigned Centril and unassigned pnkfelix Mar 31, 2019
@Centril Centril added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. relnotes Marks issues that should be documented in the release notes of the next release. labels Mar 31, 2019
@Centril Centril added this to the 1.35 milestone Mar 31, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
@jmcomets
Copy link
Contributor Author

There's an issue with the tidy check in the Travis build, @Centril do you mind giving me some help figuring it out?

Here's what I pinpointed:

tidy error: /checkout/src/libcore/cell.rs:721: mismatches the `issue` in corresponding lang feature

I understand that the feature entry isn't valid, but I'm not sure what to put instead. ☹️

@Centril
Copy link
Contributor

Centril commented Mar 31, 2019

@jmcomets Good eye! It should just go away with your last commit. :)

@Centril
Copy link
Contributor

Centril commented Mar 31, 2019

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 31, 2019

📌 Commit c789a53 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 31, 2019
Centril added a commit to Centril/rust that referenced this pull request Mar 31, 2019
@Centril
Rollup merge of rust-lang#59581 - jmcomets:stabilize-refcell_replace_…
9d198db 
…swap, r=Centril

Stabilize refcell_replace_swap feature

Please be kind, this is my first time contributing. 😄

I noticed rust-lang#43570 only needs stabilizing (and I need it for a side project I'm working on), so I followed the [guide](https://rust-lang.github.io/rustc-guide/stabilization_guide.html#stabilization-pr) to move things forward.

I'm happy to amend things if needed, let me know!
@Centril Centril mentioned this pull request Mar 31, 2019
Merged
bors added a commit that referenced this pull request Mar 31, 2019
@bors
Auto merge of #59590 - Centril:rollup, r=Centril
4fac5c9 
Rollup of 7 pull requests

Successful merges:

 - #58805 (Lint for redundant imports)
 - #59506 (Use platform dependent mcount function)
 - #59519 (rustc_target: factor out common fields of non-Single Variants.)
 - #59580 (Allow closure to unsafe fn coercion)
 - #59581 (Stabilize refcell_replace_swap feature)
 - #59583 (match match match match match)
 - #59587 (Remove #[doc(hidden)] from Error::type_id)

Failed merges:

r? @ghost
@bors bors merged commit c789a53 into rust-lang:master Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centril Centril Centril approved these changes

Assignees

@Centril Centril

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.35
Development

Successfully merging this pull request may close these issues.
5 participants
@jmcomets @rust-highfive @Centril @bors @pnkfelix