Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove no_force from coherent_trait #59723

Merged
merged 1 commit into from
Apr 6, 2019
Merged

Remove no_force from coherent_trait #59723

merged 1 commit into from
Apr 6, 2019

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Apr 5, 2019

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 5, 2019
@michaelwoerister
Copy link
Member

Thanks, @Zoxc! r=me once travis turns green.

@Zoxc
Copy link
Contributor Author

Zoxc commented Apr 5, 2019

@bors r=michaelwoerister

@bors
Copy link
Contributor

bors commented Apr 5, 2019

📌 Commit 25c448f has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 5, 2019
@bors
Copy link
Contributor

bors commented Apr 6, 2019

⌛ Testing commit 25c448f with merge b025802...

bors added a commit that referenced this pull request Apr 6, 2019
@bors
Auto merge of #59723 - Zoxc:rem-noforce, r=michaelwoerister
b025802 
Remove no_force from coherent_trait

r? @michaelwoerister
@bors
Copy link
Contributor

bors commented Apr 6, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: michaelwoerister
Pushing b025802 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 6, 2019
@bors bors merged commit 25c448f into rust-lang:master Apr 6, 2019
@Zoxc Zoxc deleted the rem-noforce branch April 6, 2019 07:41
@michaelwoerister
Copy link
Member

This indeed fixed the perf.rlo problem \o/

@michaelwoerister
Copy link
Member

cc @Mark-Simulacrum

@pnkfelix pnkfelix mentioned this pull request Apr 11, 2019
Closed
@Zoxc Zoxc mentioned this pull request May 10, 2019
Closed
@michaelwoerister michaelwoerister mentioned this pull request May 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelwoerister michaelwoerister

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Zoxc @michaelwoerister @bors @rust-highfive