Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix async desugaring providing wrong input to procedural macros. #60676

Merged
merged 3 commits into from
May 10, 2019
Merged

Fix async desugaring providing wrong input to procedural macros. #60676

merged 3 commits into from
May 10, 2019

Commits on May 9, 2019

  1. Add regression test for rust-lang#60674. 

    This commit adds a regression test (with current broken behaviour) that
tests that `mut` patterns are not lost when provided as input to a proc macro.
    @davidtwco
    davidtwco committed May 9, 2019
    Configuration menu
    Copy the full SHA
    e57c7b8 View commit details
    Browse the repository at this point in the history

  2. Do not modify mutability of simple bindings. 

    This commit removes the modification of the mutability of simple
bindings. While the mutability isn't used, it is important that it is
kept so that the input to procedural macros matches what the user wrote.
This commit also modifies the span of the binding mode so that it is
considered a compiler desugaring and won't be linted against for being
unused..
    @davidtwco
    davidtwco committed May 9, 2019
    Configuration menu
    Copy the full SHA
    dcd3cf7 View commit details
    Browse the repository at this point in the history

  3. Add FIXME about construct_async_arguments. 

    This is unrelated to the rest of this PR but it made sense to add a
FIXME explaining that the function shouldn't really be in the parser.
    @davidtwco
    davidtwco committed May 9, 2019
    Configuration menu
    Copy the full SHA
    d5e0406 View commit details
    Browse the repository at this point in the history