Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[let_chains, 2/6] Introduce Let(..) in AST, remove IfLet + WhileLet and parse let chains #60861

Merged
merged 35 commits into from
Jun 23, 2019
Merged

[let_chains, 2/6] Introduce Let(..) in AST, remove IfLet + WhileLet and parse let chains #60861

merged 35 commits into from
Jun 23, 2019
+2,334 −625

Commits on Jun 22, 2019

  1. let_chains: Remove ast::ExprKind::{IfLet, WhileLet} and introduce ::Let.

    @Centril
    Centril committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    42accc9 View commit details
    Browse the repository at this point in the history

  2. let_chains: Remove ast::ExprKind::{IfLet, WhileLet} from visitors and… 

    … introduce ::Let.
    @Centril
    Centril committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    f0ab633 View commit details
    Browse the repository at this point in the history

  3. let_chains: Handle it in AST pretty printing.

    @Centril
    Centril committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    3fc9642 View commit details
    Browse the repository at this point in the history

  4. let_chains: Add support for parsing let expressions.

    @Centril
    Centril committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    dff1e37 View commit details
    Browse the repository at this point in the history

  5. let_chains: Handle in resolve.

    @Centril
    Centril committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    70a65e9 View commit details
    Browse the repository at this point in the history

  6. let_chains: Handle in unused parenthesis lint.

    @Centril
    Centril committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    fcffac5 View commit details
    Browse the repository at this point in the history

  7. let_chains: Handle disallowing of let chains in places lowering won't… 

    … support.
    @Centril
    Centril committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    a7b00f5 View commit details
    Browse the repository at this point in the history

  8. let_chains: Adjust lowering logic in lieu of ::Let.

    @Centril
    Centril committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    c9fb639 View commit details
    Browse the repository at this point in the history

  9. let_chains: Add feature gate.

    @Centril
    Centril committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    ebea1c2 View commit details
    Browse the repository at this point in the history

  10. let_chains: Add tests for places where let expressions aren't allowed.

    @Centril
    Centril committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    357b499 View commit details
    Browse the repository at this point in the history

  11. let_chains: Add feature gate tests.

    @Centril
    Centril committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    c0c5791 View commit details
    Browse the repository at this point in the history

  12. let_chains: Adjust unnecessary parens tests.

    @Centril
    Centril committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    6a6b079 View commit details
    Browse the repository at this point in the history

  13. let_chains: Add test protecting the precedence of && in relation to o… 

    …ther things.
    @Centril
    Centril committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    d45dadd View commit details
    Browse the repository at this point in the history

  14. let_chains: Remove redundant tests in syntax-ambiguity-*.rs.

    @Centril
    Centril committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    b425df0 View commit details
    Browse the repository at this point in the history

  15. let_chains: Test pretty output for simple stable if-let.

    @Centril
    Centril committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    530f954 View commit details
    Browse the repository at this point in the history

  16. let_chains: Comment out Let in ident_can_begin_expr.

    @Centril
    Centril committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    86250a6 View commit details
    Browse the repository at this point in the history

  17. let_chains: Improve documentation for ast::ExprKind::Let(..).

    @Centril
    Centril committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    8b72e4c View commit details
    Browse the repository at this point in the history

  18. let_chains: Fix outdated doc-comment re. 'parse_if_expr'.

    @Centril
    Centril committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    3b7f0cb View commit details
    Browse the repository at this point in the history

  19. let_chains: scrutinee -> head expression.

    @Centril
    Centril committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    1ff947f View commit details
    Browse the repository at this point in the history

  20. let_chains: Change AST validation strategy slightly.

    @Centril
    Centril committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    a80aa34 View commit details
    Browse the repository at this point in the history

  21. let_chains: Account for const generics in validation tests.

    @Centril
    Centril committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    07f37c8 View commit details
    Browse the repository at this point in the history

  22. let_chains: scrutinee -> condition

    @Centril
    Centril committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    a505d9d View commit details
    Browse the repository at this point in the history

  23. let_chains: Fuse PatternSource::Let & ::LetExpr.

    @Centril
    Centril committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    61fc727 View commit details
    Browse the repository at this point in the history

  24. let_chains: readd kw::let to ident_can_begin_expr.

    @Centril
    Centril committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    92587e4 View commit details
    Browse the repository at this point in the history

  25. let_chains: Inline visit_expr_with_let_maybe_allowed.

    @Centril
    Centril committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    d551880 View commit details
    Browse the repository at this point in the history

  26. let_chains: Move feature gating to pre-expansion.

    @Centril
    Centril committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    eb4f54a View commit details
    Browse the repository at this point in the history

  27. let_chains: Adjust tests for pre-expansion gating.

    @Centril
    Centril committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    10234d2 View commit details
    Browse the repository at this point in the history

  28. let_chains: Remove ast_validation logic in favor of lowering with rec… 

    …overy.
    @Centril
    Centril committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    2017be4 View commit details
    Browse the repository at this point in the history

  29. let_chains: --bless tests due to recovery in lowering.

    @Centril
    Centril committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    5ae5086 View commit details
    Browse the repository at this point in the history

  30. let_chains: Refactor parse_{if,while}_expr a bit.

    @Centril
    Centril committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    7465eb4 View commit details
    Browse the repository at this point in the history

  31. let_chains: Fix bugs in pretty printing.

    @Centril
    Centril committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    851066f View commit details
    Browse the repository at this point in the history

  32. let_chains: Add test cases to pprust-expr-roundtrip.

    @Centril
    Centril committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    bc72ce6 View commit details
    Browse the repository at this point in the history

  33. let_chains: More accurately describe ast::ExprKind::Let. 

    Co-Authored-By: Vadim Petrochenkov <[email protected]>
    @Centril @petrochenkov
    Centril and petrochenkov committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    90b9e96 View commit details
    Browse the repository at this point in the history

  34. let_chains: Revert 'fn with' in ast_validation.

    @Centril
    Centril committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    7abb235 View commit details
    Browse the repository at this point in the history

  35. let_chains: note re. back-compat wrt. expr beginning.

    @Centril
    Centril committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    c75f7ec View commit details
    Browse the repository at this point in the history