make sure we use cfg-if as a std dependency #61828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cramertj (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
I found no place that enabled the feature. So, I have no idea how this even builds during bootstrap, without using that feature. |
|
@bors: r+ |
|
📌 Commit e5f840e has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 500, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
|
To unbreak a tool: |
This was referenced Jun 14, 2019
Merged
|
⌛ Testing commit e5f840e with merge 6d21a1336e037a1836d54f4f3981c4d12b41b185... |
|
@bors retry yielding prio to r0llup |
|
⌛ Testing commit e5f840e with merge 1b36b29cb67c3618ec2774d4b1879cc332485f92... |
|
💔 Test failed - checks-travis |
bors
added
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
Spurious macOS failure "error: linking with @bors retry |
bors
added
S-waiting-on-bors
|
⌛ Testing commit e5f840e with merge 2c2f4d13c6be718878749d17712d499cf01a973f... |
|
💔 Test failed - checks-travis |
|
Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
added
S-waiting-on-review
|
Broken apt stuff...?!? Seems spurious. Cc @rust-lang/infra @bors retry |
bors
added
S-waiting-on-bors
|
⌛ Testing commit e5f840e with merge 58a75bfc6a6a39f779e515a71b792ed77bc76f78... |
|
@bors retry yielding to r0llup |
|
So another day will go by where the "latest available Miri" is a broken Miri. :( To be clear, not only is the toolstate red (which is not a big deal), also if people install what https://rust-lang.github.io/rustup-components-history/ shows as the latest version that contains Miri, they will get something that is broken. That's bad. |
bors
added a commit
that referenced
this pull request
Jun 15, 2019
make sure we use cfg-if as a std dependency xargo currently fails to build libstd because this feature is missing. My guess is that it works in rustc because the feature is enabled elsewhere, but that does not help for a libstd-only build. Miri is currently in a state where it is shipped but broken, which makes CI fail for projects that are tested in Miri. So this is kind of urgent. Cc @alexcrichton #61720
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xargo currently fails to build libstd because this feature is missing. My guess is that it works in rustc because the feature is enabled elsewhere, but that does not help for a libstd-only build.
Miri is currently in a state where it is shipped but broken, which makes CI fail for projects that are tested in Miri. So this is kind of urgent.
Cc @alexcrichton #61720