Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Place::as_place_ref is now Place::as_ref #62859

Merged
merged 1 commit into from
Jul 23, 2019
Merged

Place::as_place_ref is now Place::as_ref #62859

merged 1 commit into from
Jul 23, 2019

Conversation

spastorino
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 21, 2019
@spastorino spastorino changed the title Place::as_place_ref is not Place::as_ref Place::as_place_ref is now Place::as_ref Jul 21, 2019
@Centril
Copy link
Contributor

Centril commented Jul 21, 2019

Seems more consistent and Oliver is busier these days... so:

r? @Centril @bors r+

@bors
Copy link
Contributor

bors commented Jul 21, 2019

📌 Commit 795d96d has been approved by Centril

@bors
Copy link
Contributor

bors commented Jul 21, 2019

🌲 The tree is currently closed for pull requests below priority 1500, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 21, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 22, 2019
@Centril
Rollup merge of rust-lang#62859 - spastorino:rename-to-as-ref, r=Centril
80aa34d 
Place::as_place_ref is now Place::as_ref

r? @oli-obk
@Centril Centril mentioned this pull request Jul 22, 2019
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 23, 2019
@Mark-Simulacrum
Rollup merge of rust-lang#62859 - spastorino:rename-to-as-ref, r=Centril
b2155dd 
Place::as_place_ref is now Place::as_ref

r? @oli-obk
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jul 23, 2019
Merged
bors added a commit that referenced this pull request Jul 23, 2019
@bors
Auto merge of #62902 - Mark-Simulacrum:rollup-mxfk0mm, r=Mark-Simulacrum
a7f2867 
Rollup of 14 pull requests

Successful merges:

 - #60951 (more specific errors in src/librustc/mir/interpret/error.rs)
 - #62523 (Delay bug to resolve HRTB ICE)
 - #62656 (explain how to search in slice without owned data)
 - #62791 (Handle more cases of typos misinterpreted as type ascription)
 - #62804 (rustc_typeck: improve diagnostics for _ const/static declarations)
 - #62808 (Revert "Disable stack probing for gnux32.")
 - #62817 (Tweak span for variant not found error)
 - #62842 (Add tests for issue-58887)
 - #62851 (move unescape module to rustc_lexer)
 - #62859 (Place::as_place_ref is now Place::as_ref)
 - #62869 (add rustc_private as a proper language feature gate)
 - #62880 (normalize use of backticks in compiler messages for librustc_allocator)
 - #62885 (Change "OSX" to "macOS")
 - #62889 (Update stage0.txt)

Failed merges:

r? @ghost
@bors bors merged commit 795d96d into rust-lang:master Jul 23, 2019
matthiaskrgr added a commit to matthiaskrgr/rust-clippy that referenced this pull request Jul 24, 2019
@matthiaskrgr
rustup rust-lang/rust#62859
2221fc8
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 24, 2019
@matthiaskrgr
submodules: update clippy from 164310d to f8e04ff
1bf17ba 
Changes:
````
update test stderr, not sure which rustc pull request caused this.
rustup rust-lang#62859
Fix tests for edition 2018 compatibility
Revert "Revert global fmt config and use `rustfmt::skip`"
Fix breakage due to rust-lang#60913
Fix breakage due to rust-lang#62705
Revert global fmt config and use `rustfmt::skip`
Fix fmt
rustup rust-lang#62679
Update pulldown-cmark to 0.5.3
rustup rust-lang#62764
Add test
Format code
Decrease maximum length for stderr files
Improved imports
Fix "unkown clippy lint" error in UI test.
Corrections for PR review.
Implement lint for inherent to_string() method.
UI Test Cleanup: Extract match_ref_pats tests
Update UI tests
Allow no_effect lint
Remove comment
cargo fmt
UI Test Cleanup: Split up checked_unwrap tests
Removed lintining on never type.
UI Test Cleanup: Split out out_of_bounds_indexing
false positives fixes of `implicit_return`
Ignore generated fresh lifetimes in elision check.
````
bors added a commit that referenced this pull request Jul 24, 2019
@bors
Auto merge of #62943 - matthiaskrgr:submodule_upd, r=Manishearth
67dd66c 
submodules: update clippy from 164310d to f8e04ff

Changes:
````
update test stderr, not sure which rustc pull request caused this.
rustup #62859
Fix tests for edition 2018 compatibility
Revert "Revert global fmt config and use `rustfmt::skip`"
Fix breakage due to #60913
Fix breakage due to #62705
Revert global fmt config and use `rustfmt::skip`
Fix fmt
rustup #62679
Update pulldown-cmark to 0.5.3
rustup #62764
Add test
Format code
Decrease maximum length for stderr files
Improved imports
Fix "unkown clippy lint" error in UI test.
Corrections for PR review.
Implement lint for inherent to_string() method.
UI Test Cleanup: Extract match_ref_pats tests
Update UI tests
Allow no_effect lint
Remove comment
cargo fmt
UI Test Cleanup: Split up checked_unwrap tests
Removed lintining on never type.
UI Test Cleanup: Split out out_of_bounds_indexing
false positives fixes of `implicit_return`
Ignore generated fresh lifetimes in elision check.
````

fixes clippy toolstate
r? @Manishearth
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 27, 2019
@matthiaskrgr
submodules: update clippy from 164310d to dc69a5c
79e6123 
Changes:
````
ci: temporarily disable rustfmt checks/tetss since it's broken for nightly
rustup rust-lang#62964
Bump version of clippy_dummy
update test stderr, not sure which rustc pull request caused this.
rustup rust-lang#62859
Fix tests for edition 2018 compatibility
Revert "Revert global fmt config and use `rustfmt::skip`"
Fix breakage due to rust-lang#60913
Fix breakage due to rust-lang#62705
Revert global fmt config and use `rustfmt::skip`
Fix fmt
rustup rust-lang#62679
Update pulldown-cmark to 0.5.3
rustup rust-lang#62764
Add test
Format code
Decrease maximum length for stderr files
Improved imports
Fix "unkown clippy lint" error in UI test.
Corrections for PR review.
Implement lint for inherent to_string() method.
UI Test Cleanup: Extract match_ref_pats tests
Update UI tests
Allow no_effect lint
Remove comment
cargo fmt
UI Test Cleanup: Split up checked_unwrap tests
Removed lintining on never type.
UI Test Cleanup: Split out out_of_bounds_indexing
false positives fixes of `implicit_return`
Ignore generated fresh lifetimes in elision check.
````
bors added a commit that referenced this pull request Jul 28, 2019
@bors
Auto merge of #62943 - matthiaskrgr:submodule_upd, r=matthiaskrgr
023525d 
submodules: update clippy from 164310d to dc69a5c

Changes:
````
ci: temporarily disable rustfmt checks/tetss since it's broken for nightly
rustup #62964
Bump version of clippy_dummy
update test stderr, not sure which rustc pull request caused this.
rustup #62859
Fix tests for edition 2018 compatibility
Revert "Revert global fmt config and use `rustfmt::skip`"
Fix breakage due to #60913
Fix breakage due to #62705
Revert global fmt config and use `rustfmt::skip`
Fix fmt
rustup #62679
Update pulldown-cmark to 0.5.3
rustup #62764
Add test
Format code
Decrease maximum length for stderr files
Improved imports
Fix "unkown clippy lint" error in UI test.
Corrections for PR review.
Implement lint for inherent to_string() method.
UI Test Cleanup: Extract match_ref_pats tests
Update UI tests
Allow no_effect lint
Remove comment
cargo fmt
UI Test Cleanup: Split up checked_unwrap tests
Removed lintining on never type.
UI Test Cleanup: Split out out_of_bounds_indexing
false positives fixes of `implicit_return`
Ignore generated fresh lifetimes in elision check.
````

fixes clippy toolstate
r? @Manishearth
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request May 5, 2020
@matthiaskrgr
submodules: update clippy from 164310d to dc69a5c
ce5a662 
Changes:
````
ci: temporarily disable rustfmt checks/tetss since it's broken for nightly
rustup rust-lang/rust#62964
Bump version of clippy_dummy
update test stderr, not sure which rustc pull request caused this.
rustup rust-lang/rust#62859
Fix tests for edition 2018 compatibility
Revert "Revert global fmt config and use `rustfmt::skip`"
Fix breakage due to rust-lang/rust#60913
Fix breakage due to rust-lang/rust#62705
Revert global fmt config and use `rustfmt::skip`
Fix fmt
rustup rust-lang/rust#62679
Update pulldown-cmark to 0.5.3
rustup rust-lang/rust#62764
Add test
Format code
Decrease maximum length for stderr files
Improved imports
Fix "unkown clippy lint" error in UI test.
Corrections for PR review.
Implement lint for inherent to_string() method.
UI Test Cleanup: Extract match_ref_pats tests
Update UI tests
Allow no_effect lint
Remove comment
cargo fmt
UI Test Cleanup: Split up checked_unwrap tests
Removed lintining on never type.
UI Test Cleanup: Split out out_of_bounds_indexing
false positives fixes of `implicit_return`
Ignore generated fresh lifetimes in elision check.
````
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Centril Centril

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spastorino @Centril @bors @oli-obk @rust-highfive