More Miri error tweaks #63245
Merged
More Miri error tweaks #63245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
oli-obk
reviewed
Aug 4, 2019
|
How will you use the experimental UB errors? Display an additional message about the experimental state? If so, don't you need to do that here? |
My plan is to first complete the categorization of errors (solving rust-lang/const-eval#4), and then look into how to best display this to the user (rust-lang/miri#417). My thinking is the latter will probably happen on the Miri side; CTFE and Miri have different needs for error display. |
|
@bors r+ |
|
📌 Commit b9d4c75 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Aug 5, 2019
More Miri error tweaks * Add `err_` version of the `_format!` macros * Add `UbExperimental` variant so that Miri can mark some UB as experimental (e.g. Stacked Borrows) r? @oli-obk
|
☀️ Test successful - checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
err_version of the_format!macrosUbExperimentalvariant so that Miri can mark some UB as experimental (e.g. Stacked Borrows)r? @oli-obk