Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let compiletest recognize gdb 10.x #71428

Merged
merged 2 commits into from
Apr 24, 2020
Merged

Let compiletest recognize gdb 10.x #71428

merged 2 commits into from
Apr 24, 2020

Commits on Apr 22, 2020

  1. Let compiletest recognize gdb 10.x 

    git gdb has moved to version 10.  My build prints this as its
--version:

    GNU gdb (GDB) 10.0.50.20200420-git

Unfortunately this conflicts with this comment in compiletest:

    // We limit major to 1 digit, otherwise, on openSUSE, we parse the openSUSE version

This patch changes the version parsing to follow the GNU coding
standard, which accounts for both the openSUSE case as well as
handling gdb 10.

My debuginfo test run now says:

NOTE: compiletest thinks it is using GDB with native rust support
NOTE: compiletest thinks it is using GDB version 10000050

... where previously it failed to find that gdb 10 had rust support.
    @tromey
    tromey committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    37097fb View commit details
    Browse the repository at this point in the history

  2. Fix compiletest version-parsing tests 

    The compiletest version-parsing tests failed after the previous patch.
However, I don't believe these tests are correct, in that I don't
think RHEL or CentOS ever put the gdb version number into parentheses.
Instead they display like:

    GNU gdb (GDB) Red Hat Enterprise Linux 7.6.1-119.el7
    @tromey
    tromey committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    90b4a97 View commit details
    Browse the repository at this point in the history