Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pointer printing: do not print 0 offset #71741

Merged
merged 1 commit into from
May 14, 2020
Merged

Pointer printing: do not print 0 offset #71741

merged 1 commit into from
May 14, 2020

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented May 1, 2020

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 1, 2020
@RalfJung
Copy link
Member Author

@oli-obk maybe we should just land this without waiting for @eddyb?

@oli-obk
Copy link
Contributor

oli-obk commented May 11, 2020

I thought I reviewed this again, and had a definite deja vu effect going through the changes

r? @oli-obk
@bors r+

@bors
Copy link
Contributor

bors commented May 11, 2020

📌 Commit 6b96fb7 has been approved by oli-obk

@rust-highfive rust-highfive assigned oli-obk and unassigned eddyb May 11, 2020
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2020
@RalfJung
Copy link
Member Author

RalfJung commented May 11, 2020 •
edited
Loading

@bors rollup

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 11, 2020
@Dylan-DPC
Rollup merge of rust-lang#71741 - RalfJung:pointer-print, r=oli-obk
bb8d391 
Pointer printing: do not print 0 offset

r? @eddyb Cc @oli-obk
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request May 11, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 12, 2020
@Dylan-DPC
Rollup merge of rust-lang#71741 - RalfJung:pointer-print, r=oli-obk
540b5d4 
Pointer printing: do not print 0 offset

r? @eddyb Cc @oli-obk
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request May 12, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 12, 2020
@Dylan-DPC
Rollup merge of rust-lang#71741 - RalfJung:pointer-print, r=oli-obk
e114d60 
Pointer printing: do not print 0 offset

r? @eddyb Cc @oli-obk
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request May 12, 2020
Closed
@Dylan-DPC-zz
Copy link

@bors r-

failed in rollup

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 12, 2020
@RalfJung RalfJung force-pushed the pointer-print branch 2 times, most recently from 7e751a6 to ff126f6 Compare May 12, 2020 10:55
@RalfJung
Copy link
Member Author

@bors r=oli-obk

@bors
Copy link
Contributor

bors commented May 12, 2020

📌 Commit 3fccdb3 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 12, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 12, 2020
@Dylan-DPC
Rollup merge of rust-lang#71741 - RalfJung:pointer-print, r=oli-obk
f453016 
Pointer printing: do not print 0 offset

r? @eddyb Cc @oli-obk
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request May 12, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 13, 2020
@Dylan-DPC
Rollup merge of rust-lang#71741 - RalfJung:pointer-print, r=oli-obk
3fd78b5 
Pointer printing: do not print 0 offset

r? @eddyb Cc @oli-obk
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request May 13, 2020
Closed
@RalfJung RalfJung mentioned this pull request May 14, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 14, 2020
@bors
Auto merge of rust-lang#72187 - RalfJung:rollup-a7a9jdi, r=RalfJung
af6d886 
Rollup of 12 pull requests

Successful merges:

 - rust-lang#71525 (`prefix` should not be mutable.)
 - rust-lang#71741 (Pointer printing: do not print 0 offset)
 - rust-lang#71870 (Be slightly more precise about any::type_name()'s guarantees.)
 - rust-lang#71909 (Document From trait for Option implementations)
 - rust-lang#71964 (Fix bootstrap failing on win32)
 - rust-lang#72137 (Clean up E0581 explanation)
 - rust-lang#72138 (Add doc comment for `rustc_middle::mir::mono::Linkage`)
 - rust-lang#72150 (Remove UnnormalizedProjection)
 - rust-lang#72151 (Update books)
 - rust-lang#72163 (docs: remove comment referencing non-existent method)
 - rust-lang#72169 (Clean up E0582 explanation)
 - rust-lang#72183 (Fix Arc::decr_strong_count doc test)

Failed merges:

r? @ghost
@bors bors merged commit 7893d9a into rust-lang:master May 14, 2020
@RalfJung RalfJung deleted the pointer-print branch May 14, 2020 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RalfJung @oli-obk @bors @Dylan-DPC-zz @eddyb @rust-highfive