Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use assert_eq for liballoc test #73017

Merged
merged 1 commit into from
Jun 5, 2020
Merged

Conversation

pickfire
Copy link
Contributor

@pickfire pickfire commented Jun 5, 2020

No description provided.

@rust-highfive
Copy link
Collaborator

r? @hanna-kruppe

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 5, 2020
@Xanewok
Copy link
Member

Xanewok commented Jun 5, 2020

@bors r? @Xanewok
@bors r+ rollup

@rust-highfive rust-highfive assigned Xanewok and unassigned hanna-kruppe Jun 5, 2020
@Xanewok
Copy link
Member

Xanewok commented Jun 5, 2020

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 5, 2020

📌 Commit b54a917 has been approved by Xanewok

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 5, 2020
@pickfire
Copy link
Contributor Author

pickfire commented Jun 5, 2020

@Xanewok Do you want me to set you as the reviewer for these kinds of issues? Because I have been changing some minor stuff for liballoc (mainly vector) recently on doctests or documentation or tests.

bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 5, 2020
Rollup of 5 pull requests

Successful merges:

 - rust-lang#72260 (Spell out `Self` in async function return)
 - rust-lang#72996 (Remove unsused `NodeId` related APIs in hir map)
 - rust-lang#73010 (Update RELEASES.md)
 - rust-lang#73017 (Use assert_eq for liballoc test)
 - rust-lang#73019 (add test for rust-lang#72960)

Failed merges:

r? @ghost
@bors bors merged commit 10d9e3c into rust-lang:master Jun 5, 2020
@pickfire pickfire deleted the liballoc-assert branch June 6, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants