Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically prioritize unsoundness issues #73181

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Automatically prioritize unsoundness issues #73181

merged 1 commit into from
Jun 11, 2020

Conversation

LeSeulArtichaut
Copy link
Contributor

r? @spastorino cc @Mark-Simulacrum @rust-lang/wg-prioritization

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 9, 2020
@spastorino
Copy link
Member

spastorino commented Jun 10, 2020 •
edited
Loading

👍, but the only problem I see is that we won't be prioritizing regressions that require nightly. I think we just wanted I-sound that do not require nightly.

@LeSeulArtichaut
Copy link
Contributor Author

I don’t think regressions that require nightly makes sense? The regressions we prioritize are stable-to-X regressions, where the require-nightly issues never reached stable.

@LeSeulArtichaut
Copy link
Contributor Author

LeSeulArtichaut commented Jun 10, 2020 •
edited
Loading

Looking through the issues, there has ever ben only 2 issues that were both require-nightly and regression issues. Also, I think it’s acceptable to skip those issues in the automatic prioritization request, since they only affect nightly features. If the bug really is important, then it can be manually requested for prioritization just like regular issues by e.g. triage folks.

Therefore, I propose that we merge this to begin prioritizing soundness issues ASAP, and discuss on Zulip whether automatically prioritizing require-nightly issues should be done. If it should, then we’ll have to implement finer-grained control in Triagebot.

@spastorino Does that seem good to you?

@spastorino
Copy link
Member

@bors r+ rollup=always

@bors
Copy link
Contributor

bors commented Jun 10, 2020

📌 Commit c9f2cbf has been approved by spastorino

@bors
Copy link
Contributor

bors commented Jun 10, 2020

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2020
RalfJung added a commit to RalfJung/rust that referenced this pull request Jun 11, 2020
@RalfJung
Rollup merge of rust-lang#73181 - LeSeulArtichaut:patch-1, r=spastorino
fef63df 
Automatically prioritize unsoundness issues

r? @spastorino cc @Mark-Simulacrum @rust-lang/wg-prioritization
@RalfJung RalfJung mentioned this pull request Jun 11, 2020
Closed
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Jun 11, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 11, 2020
@bors
Auto merge of rust-lang#73235 - Dylan-DPC:rollup-zp8oxhg, r=Dylan-DPC
50c0192 
Rollup of 11 pull requests

Successful merges:

 - rust-lang#72380 (Fix `is_const_context`, update `check_for_cast`)
 - rust-lang#72941 (Ensure stack when building MIR for matches)
 - rust-lang#72976 (Clean up E0642 explanation)
 - rust-lang#73080 (doc/rustdoc: Fix incorrect external_doc feature flag)
 - rust-lang#73155 (save_analysis: better handle paths and functions signature)
 - rust-lang#73164 (Add new E0762 error code)
 - rust-lang#73172 (Fix more clippy warnings)
 - rust-lang#73181 (Automatically prioritize unsoundness issues)
 - rust-lang#73183 (Support proc macros in intra doc link resolution)
 - rust-lang#73208 (Fix doctest template)
 - rust-lang#73219 (x.py: with --json-output, forward cargo's JSON)

Failed merges:

r? @ghost
@bors bors merged commit 6cc757e into rust-lang:master Jun 11, 2020
@LeSeulArtichaut LeSeulArtichaut deleted the patch-1 branch June 11, 2020 15:04
@LeSeulArtichaut LeSeulArtichaut mentioned this pull request Jun 11, 2020
Closed
@cuviper cuviper added this to the 1.46 milestone May 2, 2024
@rustbot
Copy link
Collaborator

rustbot commented May 2, 2024

Error: Invalid triagebot.toml at position 41:1:

TOML parse error at line 41, column 1
   |
41 | prioritize_on = [
   | ^^^^^^^^^^^^^
unknown field `prioritize_on`, expected `label`

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@spastorino spastorino

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.46
Development

Successfully merging this pull request may close these issues.
6 participants
@LeSeulArtichaut @spastorino @bors @rustbot @cuviper @rust-highfive