Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typeck: report placeholder type error w/out span #74270

Merged

Conversation

davidtwco
Copy link
Member

Fixes #74086.

This PR fixes a regression introduced in #70369 which meant that an error was not being emitted for invalid placeholder types when there wasn't a span available.

r? @estebank

This commit fixes a regression introduced in rust-lang#70369 which
meant that an error was not being emitted for invalid placeholder types
when there wasn't a span available.

Signed-off-by: David Wood <[email protected]>
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 12, 2020
Comment on lines 33 to +35
fn test8(_f: fn() -> _) { }
//~^ ERROR the type placeholder `_` is not allowed within types on item signatures
//~^^ ERROR the type placeholder `_` is not allowed within types on item signatures
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunate.

@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jul 12, 2020

📌 Commit 5afbc52 has been approved by estebank

@bors
Copy link
Contributor

bors commented Jul 12, 2020

🌲 The tree is currently closed for pull requests below priority 20, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 12, 2020
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 13, 2020
…der-type-error, r=estebank

typeck: report placeholder type error w/out span

Fixes rust-lang#74086.

This PR fixes a regression introduced in rust-lang#70369 which meant that an error was not being emitted for invalid placeholder types when there wasn't a span available.

r? @estebank
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 13, 2020
…der-type-error, r=estebank

typeck: report placeholder type error w/out span

Fixes rust-lang#74086.

This PR fixes a regression introduced in rust-lang#70369 which meant that an error was not being emitted for invalid placeholder types when there wasn't a span available.

r? @estebank
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 13, 2020
…der-type-error, r=estebank

typeck: report placeholder type error w/out span

Fixes rust-lang#74086.

This PR fixes a regression introduced in rust-lang#70369 which meant that an error was not being emitted for invalid placeholder types when there wasn't a span available.

r? @estebank
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 13, 2020
…der-type-error, r=estebank

typeck: report placeholder type error w/out span

Fixes rust-lang#74086.

This PR fixes a regression introduced in rust-lang#70369 which meant that an error was not being emitted for invalid placeholder types when there wasn't a span available.

r? @estebank
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 14, 2020
…der-type-error, r=estebank

typeck: report placeholder type error w/out span

Fixes rust-lang#74086.

This PR fixes a regression introduced in rust-lang#70369 which meant that an error was not being emitted for invalid placeholder types when there wasn't a span available.

r? @estebank
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 14, 2020
…der-type-error, r=estebank

typeck: report placeholder type error w/out span

Fixes rust-lang#74086.

This PR fixes a regression introduced in rust-lang#70369 which meant that an error was not being emitted for invalid placeholder types when there wasn't a span available.

r? @estebank
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 14, 2020
…arth

Rollup of 15 pull requests

Successful merges:

 - rust-lang#71237 (Add Ayu theme to rustdoc)
 - rust-lang#73720 (Clean up E0704 error explanation)
 - rust-lang#73866 (Obviate #[allow(improper_ctypes_definitions)])
 - rust-lang#73965 (typeck: check for infer before type impls trait)
 - rust-lang#73986 (add (unchecked) indexing methods to raw (and NonNull) slices)
 - rust-lang#74173 (Detect tuple struct incorrectly used as struct pat)
 - rust-lang#74220 (Refactor Windows `parse_prefix`)
 - rust-lang#74227 (Remove an unwrap in layout computation)
 - rust-lang#74239 (Update llvm-project to latest origin/rustc/10.0-2020-05-05 commit )
 - rust-lang#74257 (don't mark linux kernel module targets as a unix environment)
 - rust-lang#74270 (typeck: report placeholder type error w/out span)
 - rust-lang#74296 (Clarify the description for rfind)
 - rust-lang#74310 (Use `ArrayVec` in `SparseBitSet`.)
 - rust-lang#74316 (Remove unnecessary type hints from Wake internals)
 - rust-lang#74324 (Update Clippy)

Failed merges:

r? @ghost
@bors bors merged commit 1114f22 into rust-lang:master Jul 14, 2020
@davidtwco davidtwco deleted the issue-74086-more-placeholder-type-error branch July 14, 2020 20:19
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ICE] Static items with an fn type which uses a wildcard results in an ICE
5 participants