Move to intra doc links for ascii.rs and panic.rs

[poliorcetics]

Helps with #75080.

@rustbot modify labels: T-doc, A-intra-doc-links, T-rustdoc

I also updated the doc to fix the wording in AsciiExt since it is now deprecated.
The two file are small changes so I bundled them together.

Some links could not be changed to make them work, I believe those are known issues with primitive types.

[rust-highfive]

r? @shepmaster

(rust_highfive has picked a reviewer for you, use r? to override)

[jyn514]

Hmm, slices are known not to work but str should work fine. There were some changes around modules vs primitives (#74063, #58699) but the link should still work with --stage 0 even if it goes to a different place.

[poliorcetics]

I tried the following with /// [`str::to_lowercase`]: ../primitive.str.html#method.to_lowercase and they both failed:

• crate::str::to_lowercase
• str::to_lowercase

EDIT: some precisions:

I rebased from a minutes-old pull of master before building and trying things.

[jyn514]

Well I'm still not sure why it's failing, but I figured out why to_lowercase fails when trim doesn't: to_lowercase is defined in alloc, not core, because it returns a String: https://doc.rust-lang.org/src/alloc/str.rs.html#360-403.

[jyn514]

Found the issue:

rust/src/librustdoc/passes/collect_intra_doc_links.rs

Lines 1230 to 1252 in cd53760

	fn primitive_impl(cx: &DocContext<'_>, path_str: &str) -> Option<DefId> {
	let tcx = cx.tcx;
	match path_str {
	"u8" => tcx.lang_items().u8_impl(),
	"u16" => tcx.lang_items().u16_impl(),
	"u32" => tcx.lang_items().u32_impl(),
	"u64" => tcx.lang_items().u64_impl(),
	"u128" => tcx.lang_items().u128_impl(),
	"usize" => tcx.lang_items().usize_impl(),
	"i8" => tcx.lang_items().i8_impl(),
	"i16" => tcx.lang_items().i16_impl(),
	"i32" => tcx.lang_items().i32_impl(),
	"i64" => tcx.lang_items().i64_impl(),
	"i128" => tcx.lang_items().i128_impl(),
	"isize" => tcx.lang_items().isize_impl(),
	"f32" => tcx.lang_items().f32_impl(),
	"f64" => tcx.lang_items().f64_impl(),
	"str" => tcx.lang_items().str_impl(),
	"bool" => tcx.lang_items().bool_impl(),
	"char" => tcx.lang_items().char_impl(),
	_ => None,
	}
	}

Note it doesn't have everything from

rust/src/librustdoc/passes/collect_trait_impls.rs

Lines 38 to 67 in cd53760

	let primitive_impls = [
	lang_items.isize_impl(),
	lang_items.i8_impl(),
	lang_items.i16_impl(),
	lang_items.i32_impl(),
	lang_items.i64_impl(),
	lang_items.i128_impl(),
	lang_items.usize_impl(),
	lang_items.u8_impl(),
	lang_items.u16_impl(),
	lang_items.u32_impl(),
	lang_items.u64_impl(),
	lang_items.u128_impl(),
	lang_items.f32_impl(),
	lang_items.f64_impl(),
	lang_items.f32_runtime_impl(),
	lang_items.f64_runtime_impl(),
	lang_items.bool_impl(),
	lang_items.char_impl(),
	lang_items.str_impl(),
	lang_items.slice_impl(),
	lang_items.slice_u8_impl(),
	lang_items.str_alloc_impl(),
	lang_items.slice_alloc_impl(),
	lang_items.slice_u8_alloc_impl(),
	lang_items.const_ptr_impl(),
	lang_items.mut_ptr_impl(),
	lang_items.const_slice_ptr_impl(),
	lang_items.mut_slice_ptr_impl(),
	];

[jyn514]

and they're in a third place, ugh. Going to clean this up as part of the fix.

rust/src/librustdoc/clean/utils.rs

Lines 372 to 398 in cd53760

	let did = match primitive {
	Isize => tcx.lang_items().isize_impl(),
	I8 => tcx.lang_items().i8_impl(),
	I16 => tcx.lang_items().i16_impl(),
	I32 => tcx.lang_items().i32_impl(),
	I64 => tcx.lang_items().i64_impl(),
	I128 => tcx.lang_items().i128_impl(),
	Usize => tcx.lang_items().usize_impl(),
	U8 => tcx.lang_items().u8_impl(),
	U16 => tcx.lang_items().u16_impl(),
	U32 => tcx.lang_items().u32_impl(),
	U64 => tcx.lang_items().u64_impl(),
	U128 => tcx.lang_items().u128_impl(),
	F32 => tcx.lang_items().f32_impl(),
	F64 => tcx.lang_items().f64_impl(),
	Char => tcx.lang_items().char_impl(),
	Bool => tcx.lang_items().bool_impl(),
	Str => tcx.lang_items().str_impl(),
	Slice => tcx.lang_items().slice_impl(),
	Array => tcx.lang_items().slice_impl(),
	Tuple => None,
	Unit => None,
	RawPointer => tcx.lang_items().const_ptr_impl(),
	Reference => None,
	Fn => None,
	Never => None,
	};

[jyn514]

@poliorcetics I have a fix for the issue in #75649. For now let's just keep it as a normal link.

[jyn514]

@bors r+ rollup

And thanks for the bug report!

[bors]

📌 Commit 0e010a6 has been approved by jyn514