Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify error reporting for intra-doc links #75916

Merged
merged 7 commits into from
Aug 29, 2020
Merged

Unify error reporting for intra-doc links #75916

merged 7 commits into from
Aug 29, 2020

Commits on Aug 25, 2020

  1. Add Res::ns() instead of matches_ns()

    @jyn514
    jyn514 committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    18e7a1b View commit details
    Browse the repository at this point in the history

  2. Unify error reporting for intra-doc links 

    - Give a suggestion even if there is no span available
- Give a more accurate description of the change than 'use the
disambiguator'
- Write much less code
    @jyn514
    jyn514 committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    56d3f39 View commit details
    Browse the repository at this point in the history

  3. Remove unused ns parameter

    @jyn514
    jyn514 committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    05a040f View commit details
    Browse the repository at this point in the history

  4. Add back Res::matches_ns, implemented in terms of ns

    @jyn514
    jyn514 committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    5ce4ee9 View commit details
    Browse the repository at this point in the history

  5. Remove outdated FIXME

    @jyn514
    jyn514 committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    e233d80 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2020

  1. Use map_or(true) instead of unwrap_or(true) 

    Co-authored-by: Ivan Tham <[email protected]>
    @jyn514 @pickfire
    jyn514 and pickfire authored Aug 26, 2020
    Configuration menu
    Copy the full SHA
    bb351de View commit details
    Browse the repository at this point in the history

  2. Note that from_res panics on errors

    @jyn514
    jyn514 authored Aug 26, 2020
    Configuration menu
    Copy the full SHA
    d3c5817 View commit details
    Browse the repository at this point in the history