Rollup of 8 pull requests #78707
Closed
Rollup of 8 pull requests #78707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes compilation without -Ztrim-diagnostic-paths=no
Per their documentation, the `max_value()` and `min_value()` associated functions have been superseded by the `MAX` and `MIN` associated constants since Rust 1.43 and are considered "soft deprecated", with all uses currently being replaced in the rustc repo.
Prefer numeric associated constants in example
Fixes bootstrapping of rustc using cg_clif Fixes rust-lang#1097
Update Cranelift
Rename trans to codegen
... to allow the subbinding of copyable fields in bindings after `@` Fixes rust-lang#69971
They have no effect there, but were silently accepted.
…ces` lint This lint was incorrectly suggesting casting a function to a pointer without specifying generic type parameters or const generics. This would cause a compiler error since the missing parameters couldn't be inferred. This commit fixed the suggestion and added a few tests with generics.
(From the PR feedback.) Co-authored-by: Esteban Küber <[email protected]>
Build system refactor
Test bootstrapping of rustc using cg_clif
Fixes rust-lang#78675 We now bail out of `prepend_attrs` if we ended up capturing any inner attributes (which can happen in several places, due to token capturing for `macro_rules!` arguments.
…g_clif-2020-11-01
Even more information to try and debug rust-lang#78665.
…ess, r=wesleywiser Properly handle lint spans after MIR inlining The first commit shows what happens when we apply mir inlining and then cause lints on the inlined MIR. The second commit fixes that. r? `@wesleywiser`
…=jyn514 Sync rustc_codegen_cranelift This fixes bootstrapping of rustc using cg_clif again. It regressed a while before rust-lang#77975 got merged. Fixes https:/bjorn3/rustc_codegen_cranelift/issues/743
…-trait-impl, r=estebank Improve errors about #[deprecated] attribute This change: 1. Turns `#[deprecated]` on a trait impl block into an error, which fixes rust-lang#78625; 2. Changes these and other errors about `#[deprecated]` to use the span of the attribute instead of the item; and 3. Turns this error into a lint, to make sure it can be capped with `--cap-lints` and doesn't break any existing dependencies. Can be reviewed per commit. --- Example: ```rust struct X; #[deprecated = "a"] impl Default for X { #[deprecated = "b"] fn default() -> Self { X } } ``` Before: ``` error: This deprecation annotation is useless --> src/main.rs:6:5 | 6 | / fn default() -> Self { 7 | | X 8 | | } | |_____^ ``` After: ``` error: this `#[deprecated]' annotation has no effect --> src/main.rs:3:1 | 3 | #[deprecated = "a"] | ^^^^^^^^^^^^^^^^^^^ help: try removing the deprecation attribute | = note: `#[deny(useless_deprecated)]` on by default error: this `#[deprecated]' annotation has no effect --> src/main.rs:5:5 | 5 | #[deprecated = "b"] | ^^^^^^^^^^^^^^^^^^^ help: try removing the deprecation attribute ```
… r=oli-obk reverse binding order in matches to allow the subbinding of copyable fields in bindings after @ Fixes rust-lang#69971 ### TODO - [x] Regression tests r? `@oli-obk`
Corrected suggestion for generic parameters in `function_item_references` lint This commit handles functions with generic type parameters like you pointed out as well as const generics. Also this is probably a minor thing, but the type alias you used in the example doesn't show up so the suggestion right now would be `size_of::<[u8; 16]> as fn() ->`. This is because the lint checker works with MIR instead of HIR. I don't think we can get the alias at that point, but let me know if I'm wrong and there's a way to fix this. Also I put you as the reviewer, but I'm not sure if you want to review it or if it makes more sense to ask one of the original reviewers of this lint. closes rust-lang#78571
…r=petrochenkov Use reparsed `TokenStream` if we captured any inner attributes Fixes rust-lang#78675 We now bail out of `prepend_attrs` if we ended up capturing any inner attributes (which can happen in several places, due to token capturing for `macro_rules!` arguments.
…acrum Suggest library/std when running all stage 0 tests r? `@Mark-Simulacrum` cc `@ijackson` For context, this came out of a discord conversation where `@ijackson` was running `test --stage 1` when they were only adding doc-tests to the standard library.
Show more error information in lldb_batchmode Even more information to try and debug rust-lang#78665.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
function_item_referenceslint #78659 (Corrected suggestion for generic parameters infunction_item_referenceslint)TokenStreamif we captured any inner attributes #78677 (Use reparsedTokenStreamif we captured any inner attributes)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup