Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimization for bool's PartialOrd impl #80035

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Optimization for bool's PartialOrd impl #80035

merged 1 commit into from
Dec 17, 2020

Conversation

ChayimFriedman2
Copy link
Contributor

@ChayimFriedman2 ChayimFriedman2 commented Dec 14, 2020 •
edited
Loading

Fix #80034.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @dtolnay (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 14, 2020
@camelid
Copy link
Member

camelid commented Dec 14, 2020

@ChayimFriedman2 Could you change your commit message and this PR title to not have "fix" in them? It can cause issues and it's better to have a descriptive title so that it's easier to figure out what the PR does. It's fine to have "fix" in the PR description though.

@camelid camelid added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Dec 14, 2020
@ChayimFriedman2 ChayimFriedman2 changed the title Fix #80034 Optimization for bool's PartialOrd impl Dec 14, 2020
@ChayimFriedman2
Copy link
Contributor Author

Done, thanks @camelid.

@jyn514 jyn514 added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Dec 14, 2020
@nagisa
Copy link
Member

nagisa commented Dec 14, 2020

r? @nagisa

@bors r+

@bors
Copy link
Contributor

bors commented Dec 14, 2020

📌 Commit 777ca99 has been approved by nagisa

@rust-highfive rust-highfive assigned nagisa and unassigned dtolnay Dec 14, 2020
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 14, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Dec 15, 2020
@Dylan-DPC
Rollup merge of rust-lang#80035 - ChayimFriedman2:patch-1, r=nagisa
185936b 
Optimization for bool's PartialOrd impl

Fix rust-lang#80034.
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Dec 15, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Dec 15, 2020
@Dylan-DPC
Rollup merge of rust-lang#80035 - ChayimFriedman2:patch-1, r=nagisa
71bc0c9 
Optimization for bool's PartialOrd impl

Fix rust-lang#80034.
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Dec 15, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Dec 15, 2020
@Dylan-DPC
Rollup merge of rust-lang#80035 - ChayimFriedman2:patch-1, r=nagisa
df630a9 
Optimization for bool's PartialOrd impl

Fix rust-lang#80034.
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Dec 15, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Dec 16, 2020
@Dylan-DPC
Rollup merge of rust-lang#80035 - ChayimFriedman2:patch-1, r=nagisa
7c61d6a 
Optimization for bool's PartialOrd impl

Fix rust-lang#80034.
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Dec 16, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Dec 16, 2020
@Dylan-DPC
Rollup merge of rust-lang#80035 - ChayimFriedman2:patch-1, r=nagisa
c6f081a 
Optimization for bool's PartialOrd impl

Fix rust-lang#80034.
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Dec 16, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Dec 16, 2020
@Dylan-DPC
Rollup merge of rust-lang#80035 - ChayimFriedman2:patch-1, r=nagisa
7496c37 
Optimization for bool's PartialOrd impl

Fix rust-lang#80034.
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Dec 16, 2020
Closed
@GuillaumeGomez GuillaumeGomez mentioned this pull request Dec 17, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 17, 2020
@bors
Auto merge of rust-lang#80114 - GuillaumeGomez:rollup-gszr5kn, r=Guil…
caeb333 
…laumeGomez

Rollup of 5 pull requests

Successful merges:

 - rust-lang#80006 (BTreeMap: more expressive local variables in merge)
 - rust-lang#80022 (BTreeSet: simplify implementation of pop_first/pop_last)
 - rust-lang#80035 (Optimization for bool's PartialOrd impl)
 - rust-lang#80040 (Always run intrinsics lowering pass)
 - rust-lang#80047 (Use more symbols in rustdoc)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 93f1c67 into rust-lang:master Dec 17, 2020
@rustbot rustbot added this to the 1.50.0 milestone Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nagisa nagisa

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.

Optimization for bool's PartialOrd impl
8 participants
@ChayimFriedman2 @rust-highfive @camelid @nagisa @bors @dtolnay @jyn514 @rustbot