Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some tests to more reasonable directories - 2 #80942

Merged
merged 1 commit into from
Jan 17, 2021

Conversation

c410-f3r
Copy link
Contributor

@c410-f3r c410-f3r commented Jan 12, 2021

All tests with a score equal or greater than 1.0 were moved to their respective directories by issuing

cat FILE | tr -s " " | tr -d '():' | sort -k3 | awk '$3 >= 1' | cut -d " " -f1-2 | sed 's;\\;/;g' | xargs -n2 git mv

Observation: The first column values is the only column with results greater zero

To attest the confidentiality of the model, some manual revision of at least of tests is needed and this process will be tracked in the following list:

...

cc #73494
r? @petrochenkov

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 12, 2021
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@bors

This comment has been minimized.

@petrochenkov
Copy link
Contributor

I've improved the report at https://gist.github.com/petrochenkov/3130672b9d5e6c4253a8fe2f34405703 with links to tests and issues for convenience.
I'll review the tests from this PR tomorrow.

@petrochenkov
Copy link
Contributor

Tests that can be removed:
typestate-cfg-nesting.rs
non-built-in-quote.rs
issue-15881-model-lexer-dotdotdot.rs

Misclassified tests, better moved elsewhere:
issue-75599.rs -> parser
issue-8460.rs -> numbers-arithmetic
issue-45199.rs -> borrowck
issue-25916.rs -> binop
issue-17545.rs -> borrowck
issue-29844.rs -> dropck
issue-30018-nopanic.rs -> drop
issue-46471.rs -> borrowck
issue-30302.rs -> lint
priv-in-bad-locations.rs -> privacy
issue-28498-ugeh-with-lifetime-param.rs -> dropck
issue-28498-ugeh-with-trait-bound.rs -> dropck
issue-12582.rs -> pattern
issue-22546.rs -> pattern
size-and-align.rs -> pattern
issue-6449.rs -> pattern
issue-38940.rs -> autoref-autoderef
issue-28848.rs -> regions
issue-51345-2.rs -> nll
issue-14221.rs -> pattern

Misclassified tests, not clear where to move, let's keep in issues for now:
issue-65634-raw-ident-suggestion.rs
issue-33140-traitobject-crate.rs
issue-65284-suggest-generic-trait-bound.rs

@petrochenkov
Copy link
Contributor

Some subdirectories that proved to be problematic - binding (a lot of misclassified tests), did_you_mean and span (pointless).
We'll need to dismantle them later once issues is dealt with.

@petrochenkov
Copy link
Contributor

@c410-f3r
Could you also update the file number limits in src\tools\tidy\src\ui_tests.rs?

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 16, 2021
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@petrochenkov
Copy link
Contributor

r=me after squashing commits.

@petrochenkov
Copy link
Contributor

@bors r+ p=1 (conflict-prone)

@bors
Copy link
Contributor

bors commented Jan 17, 2021

📌 Commit ad35979 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 17, 2021
@bors
Copy link
Contributor

bors commented Jan 17, 2021

⌛ Testing commit ad35979 with merge 95cbcad...

@bors
Copy link
Contributor

bors commented Jan 17, 2021

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 95cbcad to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 17, 2021
@bors bors merged commit 95cbcad into rust-lang:master Jan 17, 2021
@rustbot rustbot added this to the 1.51.0 milestone Jan 17, 2021
@m-ou-se
Copy link
Member

m-ou-se commented Jan 17, 2021

Could you also update the file number limits in src\tools\tidy\src\ui_tests.rs?

Was it intentional that not even a single new ui test can be added in src/test/ui/issues? (E.g. #81071 failed because it added a new test.)

@petrochenkov
Copy link
Contributor

@m-ou-se
It's better to move the test from #81071 to ui/macros.
We can relax tidy, but then one of the next added tests will trigger tidy, so there's probably not much difference.

@camelid camelid added A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants