Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 11 pull requests #88854

Closed
wants to merge 42 commits into from

Commits on Aug 10, 2021

  1. Reword description of automatic impls of Unsize.

    The existing documentation felt a little unhelpfully concise, so this
    change tries to improve it by using longer sentences, each of which
    specifies which kinds of types it applies to as early as possible. In
    particular, the third item starts with “Structs ...” instead of
    saying “Foo is a struct” later.
    
    Also, the previous list items “Only the last field has a type
    involving `T`” and “`T` is not part of the type of any other
    fields” are, as far as I see, redundant with each other, so I removed
    the latter.
    kpreid committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    07988bb View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2021

  1. Configuration menu
    Copy the full SHA
    2884a74 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2021

  1. Configuration menu
    Copy the full SHA
    4d6bfde View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2021

  1. Add explanatory comment

    FabianWolff committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    bbe3be9 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2021

  1. Change more x64 size checks to not apply to x32.

    Commit 95e096d changed a bunch of size checks already, but more have
    been added, so this fixes the new ones the same way: the various size
    checks that are conditional on target_arch = "x86_64" were not intended
    to apply to x86_64-unknown-linux-gnux32, so add
    target_pointer_width = "64" to the conditions.
    hvdijk committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    cd75af2 View commit details
    Browse the repository at this point in the history
  2. Don't build the library and standard library before documenting them

    Rustdoc doesn't require the build artifacts to generate the docs, and
    especially in the case of rustc, it greatly increases the time needed to
    run the build.
    jyn514 committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    04db063 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2021

  1. Configuration menu
    Copy the full SHA
    e2d01ed View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2021

  1. WIP state

    BoxyUwU committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    2987f4b View commit details
    Browse the repository at this point in the history
  2. as casts and block exprs

    BoxyUwU committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    9b29138 View commit details
    Browse the repository at this point in the history
  3. dont support blocks

    BoxyUwU committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    4483c2b View commit details
    Browse the repository at this point in the history
  4. bless stderr

    BoxyUwU committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    47b16f4 View commit details
    Browse the repository at this point in the history
  5. tidy

    BoxyUwU committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    c170dcf View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    08e8644 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    fc63e9a View commit details
    Browse the repository at this point in the history
  8. handle ExprKind::NeverToAny

    BoxyUwU committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    4cbcb09 View commit details
    Browse the repository at this point in the history
  9. remove WorkNode

    BoxyUwU committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    1f57f8b View commit details
    Browse the repository at this point in the history
  10. remove debug stmts

    BoxyUwU committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    15101c8 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    406d2ab View commit details
    Browse the repository at this point in the history
  12. remove comment

    BoxyUwU committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    79be080 View commit details
    Browse the repository at this point in the history
  13. nits

    BoxyUwU committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    955e2b2 View commit details
    Browse the repository at this point in the history
  14. add a CastKind to Node::Cast

    BoxyUwU committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    8c7954d View commit details
    Browse the repository at this point in the history
  15. resolve from_hir_call FIXME

    BoxyUwU committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    3212734 View commit details
    Browse the repository at this point in the history
  16. fmt

    BoxyUwU committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    cd2915e View commit details
    Browse the repository at this point in the history
  17. CI please

    BoxyUwU committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    fd9bb30 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    dc02b51 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    8295e4a View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2021

  1. Configuration menu
    Copy the full SHA
    64354a9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    88d5aa6 View commit details
    Browse the repository at this point in the history
  3. Add help for E0463

    GuillaumeGomez committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    c9a56cd View commit details
    Browse the repository at this point in the history
  4. rustc: Remove local variable IDs from Exports

    Local variables can never be exported.
    petrochenkov committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    294510e View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2021

  1. Configuration menu
    Copy the full SHA
    c1e9608 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#87904 - kpreid:unsize, r=jyn514

    Reword description of automatic impls of `Unsize`.
    
    The existing documentation felt a little unhelpfully concise, so this change tries to improve it by using longer sentences, each of which specifies which kinds of types it applies to as early as possible. In particular, the third item starts with “Structs ...” instead of saying “Foo is a struct” later.
    
    Also, the previous list items “Only the last field has a type involving `T`” and “`T` is not part of the type of any other fields” are, as far as I see, redundant with each other, so I removed the latter.
    
    I have no particular knowledge of `Unsize`; I have attempted to leave the meaning entirely unchanged but may have missed a nuance.
    
    Markdown preview of the edited documentation:
    
    > All implementations of `Unsize` are provided automatically by the compiler.
    > Those implementations are:
    >
    > - Arrays `[T; N]` implement `Unsize<[T]>`.
    > - Types implementing a trait `Trait` also implement `Unsize<dyn Trait>`.
    > - Structs `Foo<..., T, ...>` implement `Unsize<Foo<..., U, ...>>` if all of these conditions
    >   are met:
    >   - `T: Unsize<U>`.
    >   - Only the last field of `Foo` has a type involving `T`.
    >   - `Bar<T>: Unsize<Bar<U>>`, where `Bar<T>` stands for the actual type of that last field.
    GuillaumeGomez authored Sep 11, 2021
    Configuration menu
    Copy the full SHA
    fd389b5 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#88147 - FabianWolff:issue-88097, r=jackh726

    Fix non-capturing closure return type coercion
    
    Fixes rust-lang#88097. For the example given there:
    ```rust
    fn peculiar() -> impl Fn(u8) -> u8 {
        return |x| x + 1
    }
    ```
    which incorrectly reports an error, I noticed something weird in the debug log:
    ```
    DEBUG rustc_typeck::check::coercion coercion::try_find_coercion_lub([[email protected]:2:12: 2:21], [[email protected]:2:12: 2:21], exprs=1 exprs)
    ```
    Apparently, `try_find_coercion_lub()` thinks that the LUB for two closure types always has to be a function pointer (which explains the `expected closure, found fn pointer` error in rust-lang#88097). There is one corner case where that isn't true, though — namely, when the two closure types are equal, in which case the trivial LUB is the type itself. This PR fixes this by inserting an explicit check for type equality in `try_find_coercion_lub()`.
    GuillaumeGomez authored Sep 11, 2021
    Configuration menu
    Copy the full SHA
    1cf99f5 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#88209 - Amanieu:asm_in_underscore, r=nagisa

    Improve error message when _ is used for in/inout asm operands
    
    As suggested by ``@Commeownist`` in rust-lang#72016 (comment).
    GuillaumeGomez authored Sep 11, 2021
    Configuration menu
    Copy the full SHA
    24fed97 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#88619 - GuillaumeGomez:simplify-std-os-reex…

    …ports, r=Amanieu
    
    Remove `cfg(doc)` from std::os module reexports to fix rustdoc linking issues
    
    Fixes rust-lang#88304.
    
    I tested it based on rust-lang#88292.
    
    Not sure if it's the best approach, but at least it makes thing a bit simpler.
    
    cc ``@jyn514``
    GuillaumeGomez authored Sep 11, 2021
    Configuration menu
    Copy the full SHA
    f064ad7 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#88668 - hvdijk:x32, r=joshtriplett

    Change more x64 size checks to not apply to x32.
    
    Commit 95e096d changed a bunch of size checks already, but more have
    been added, so this fixes the new ones the same way: the various size
    checks that are conditional on target_arch = "x86_64" were not intended
    to apply to x86_64-unknown-linux-gnux32, so add
    target_pointer_width = "64" to the conditions.
    GuillaumeGomez authored Sep 11, 2021
    Configuration menu
    Copy the full SHA
    a21eaa4 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#88675 - jyn514:faster-doc, r=Mark-Simulacrum

    Don't build the compiler and standard library before documenting them
    
    Rustdoc doesn't require the build artifacts to generate the docs, and
    especially in the case of rustc, it greatly increases the time needed to
    run the build.
    
    r? ``@Mark-Simulacrum`` cc ``@steffahn``
    GuillaumeGomez authored Sep 11, 2021
    Configuration menu
    Copy the full SHA
    0235d0b View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#88677 - petrochenkov:exportid, r=davidtwco

    rustc: Remove local variable IDs from `Export`s
    
    Local variables can never be exported.
    GuillaumeGomez authored Sep 11, 2021
    Configuration menu
    Copy the full SHA
    78b5acc View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#88709 - BoxyUwU:thir-abstract-const, r=lcnr

    generic_const_exprs: use thir for abstract consts instead of mir
    
    not sure if this is handling some of the weirder `thir::ExprKind` correctly in `recurse_build` (it probably isnt)
    
    r? ``@lcnr``
    GuillaumeGomez authored Sep 11, 2021
    Configuration menu
    Copy the full SHA
    abb31d6 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#88779 - estebank:unused-delims, r=davidtwco

    Use more accurate spans for "unused delimiter" lint
    GuillaumeGomez authored Sep 11, 2021
    Configuration menu
    Copy the full SHA
    9f98345 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#88830 - GuillaumeGomez:help-e0463, r=estebank

    Add help for E0463
    
    Fixes rust-lang#87871.
    
    r? ``@estebank``
    GuillaumeGomez authored Sep 11, 2021
    Configuration menu
    Copy the full SHA
    9c7edef View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#88849 - matthiaskrgr:clony_on_copy, r=petro…

    …chenkov
    
    don't clone types that are Copy (clippy::clone_on_copy)
    GuillaumeGomez authored Sep 11, 2021
    Configuration menu
    Copy the full SHA
    35b66f8 View commit details
    Browse the repository at this point in the history