Support incremental in compiletest for non-incremental modes. #89101
Conversation
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
There was prior discussion about this at https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/Incremental.20ICE.20running.20rustc.20tests.20on.20origin.2Fmaster/near/251211217 It was suggested that these tests could be moved to the incremental directory, but I don't think that is possible because these are codegen tests which are tested differently. I'm not familiar with these tests, so maybe they can be moved, so let me know if an alternate solution would be preferred. |
|
I think we should also consider renaming the flag to "incremental" or "incremental-mode" -- I want to avoid accidentally reading it as similar to 'build-pass' or otherwise tying it specifically to build in that sense. r=me with the docs and a possible rename, happy to leave it up to you which to choose -- or if you feel strongly about -build, that's also OK. |
Mark-Simulacrum
added
S-waiting-on-author
ehuss
force-pushed
the
compiletest-incremental-build
branch
from
6a1342a
to
2da6e66
Compare
|
Yea, I can see how that can be confusing with I went ahead and renamed it back to just I kinda wish the header parsing was a little more strict so that risk of accidental matches wasn't there. Feel free to r- if that doesn't sound good, or if the comment I added isn't correct or clear. |
|
@bors r=Mark-Simulacrum |
|
📌 Commit 2da6e66 has been approved by |
bors
added
S-waiting-on-bors
|
Sounds great, thanks! Yeah, our header parsing story is not great :) |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (ac8dd1b): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
These used to be used by codegen-units tests, but were switched from manually specifying directories to just using `// incremental` in rust-lang#89101. Remove the old references.
…acrum Remove references to `./tmp` in-tree These used to be used by codegen-units tests, but were switched from manually specifying directories to just using `// incremental` in rust-lang#89101. Remove the old references. Fixes rust-lang#34586.
This adds first-class support for using incremental builds in non-incremental-mode tests. These tests previously manually passed
-C incremental=tmp/foowhich resulted in reusing the same tmp folder between runs. This means that these tests could fail whenever the on-disk incremental format changed (such as when updating one's local source tree). This changes it so that these tests can pass a// incremental-buildheader which instructs compiletest to create a set aside a dedicated incremental directory which will be cleared before the test starts to ensure it has a clean slate.