Fix performance regression with #[instrument]

[oli-obk]

linked tracing PR: tokio-rs/tracing#1600

regression introduced by #89048

[oli-obk]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 30c3b7e0fe425917bd8356ed3334b216243b3e96 with merge b5602a152eaddec13f5618989f4828d111cdfef2...

[bors]

💔 Test failed - checks-actions

[oli-obk]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit a9076811504e29807cde539aeeae2b4c9ecc530e with merge fa066f98f2e0ca15f41722c40c5cee5c7d71fddb...

[bors]

💔 Test failed - checks-actions

[oli-obk]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit d40c21b734cb5e7d1689d85e5fb5022018a525a6 with merge 3faf913e5755711caf4fddb8a822679e4584afbc...

[bors]

☀️ Try build successful - checks-actions
Build commit: 3faf913e5755711caf4fddb8a822679e4584afbc (3faf913e5755711caf4fddb8a822679e4584afbc)

[rust-timer]

Queued 3faf913e5755711caf4fddb8a822679e4584afbc with parent 50f9f78, future comparison URL.

[rust-timer]

Finished benchmarking commit (3faf913e5755711caf4fddb8a822679e4584afbc): comparison url.

Summary: This change led to very large relevant mixed results 🤷 in compiler performance.

• Very large improvement in instruction counts (up to -10.8% on full builds of ctfe-stress-4)
• Large regression in instruction counts (up to 1.3% on incr-unchanged builds of helloworld)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

[oli-obk]

r? rust-lang/compiler

[joshtriplett]

Reviewing the results, this looks like a substantial improvement.

[Mark-Simulacrum]

I do note that tracing-subscriber now takes ~1.8x as long to compile -- some of that might be noise, but maybe worth mentioning upstream.

The minor performance regressions on a number of benchmarks do seem to be outweighed by the far larger and more consistent wins, though, so this seems good to merge to me in the meantime - we can always bump again if there's further improvements (e.g., to tracing-subscriber compile times).

@bors r+

[bors]

📌 Commit 69274aa has been approved by Mark-Simulacrum

[bors]

⌛ Testing commit 69274aa with merge 25ec827...

[bors]

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 25ec827 to master...

[rust-timer]

Finished benchmarking commit (25ec827): comparison url.

Summary: This change led to very large relevant improvements 🎉 in compiler performance.

• Very large improvement in instruction counts (up to -11.3% on full builds of ctfe-stress-4)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression