Add #[must_use] to alloc functions that would leak memory #90427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
jkugelman
force-pushed
the
must-use-alloc-leak
branch
from
b0c783b
to
42e0282
Compare
joshtriplett
added
the
relnotes
|
@bors r+ |
|
📌 Commit 42e0282 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 31, 2021
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#89446 (Add paragraph to ControlFlow docs to menion it works with the ? operator (rust-lang#88715)) - rust-lang#89677 (Stabilize `is_symlink()` for `Metadata` and `Path`) - rust-lang#89833 (Add #[must_use] to Rc::downgrade) - rust-lang#89835 (Add #[must_use] to expensive computations) - rust-lang#89839 (Add #[must_use] to mem/ptr functions) - rust-lang#89897 (Add #[must_use] to remaining core functions) - rust-lang#89951 (Stabilize `option_result_unwrap_unchecked`) - rust-lang#90427 (Add #[must_use] to alloc functions that would leak memory) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
matklad
reviewed
Nov 30, 2021
| @@ -804,6 +804,7 @@ impl<T: ?Sized> Arc<T> { | |||
| /// let x_ptr = Arc::into_raw(x); | |||
| /// assert_eq!(unsafe { &*x_ptr }, "hello"); | |||
| /// ``` | |||
| #[must_use = "losing the pointer will leak memory"] | |||
There was a problem hiding this comment.
This one feels like it could lead to false positives. This is Arc, so you can get the data back via another instance.
not sure if it happens in practice though. I think I used that once to simulate
increment_strong_count? Not sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @joshtriplett.
I added
reallocmyself. Clippy ignored it because of itsmutargument.Parent issue: #89692
r? @joshtriplett