Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-export some iterators from core in std #90604

Merged
merged 4 commits into from
Nov 5, 2021

Conversation

mbartlett21
Copy link
Contributor

These iterators seem to have been forgotten to be re-exported from std (through alloc)

These are stable:

core::slice::{SplitInclusive, SplitInclusiveMut}

This one is still unstable:

core::slice::EscapeAscii (cc #77174)

@rust-highfive
Copy link
Collaborator

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 5, 2021
@rust-log-analyzer

This comment has been minimized.

@kennytm
Copy link
Member

kennytm commented Nov 5, 2021

error[E0658]: use of unstable library feature 'inherent_ascii_escape'
   --> library/alloc/src/slice.rs:112:9
    |
112 | pub use core::slice::EscapeAscii;
    |         ^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #77174 <https:/rust-lang/rust/issues/77174> for more information
    = help: add `#![feature(inherent_ascii_escape)]` to the crate attributes to enable

@rust-log-analyzer

This comment has been minimized.

@@ -46,7 +46,7 @@ pub use core::str::pattern;
pub use core::str::EncodeUtf16;
#[stable(feature = "split_ascii_whitespace", since = "1.34.0")]
pub use core::str::SplitAsciiWhitespace;
#[stable(feature = "split_inclusive", since = "1.53.0")]
#[stable(feature = "split_inclusive", since = "1.51.0")]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was actually incorrect. It hadn't been picked up, since it was across crates.

@kennytm
Copy link
Member

kennytm commented Nov 5, 2021

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 5, 2021

📌 Commit ed63c71 has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 5, 2021
@bors
Copy link
Contributor

bors commented Nov 5, 2021

⌛ Testing commit ed63c71 with merge d22dd65...

@bors
Copy link
Contributor

bors commented Nov 5, 2021

☀️ Test successful - checks-actions
Approved by: kennytm
Pushing d22dd65 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 5, 2021
@bors bors merged commit d22dd65 into rust-lang:master Nov 5, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 5, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d22dd65): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@mbartlett21 mbartlett21 deleted the iterator-reexports branch November 6, 2021 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants