Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couple of libtest cleanups #92409

Merged
merged 4 commits into from
Jan 3, 2022
Merged

Couple of libtest cleanups #92409

merged 4 commits into from
Jan 3, 2022

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Dec 29, 2021

Remove the unnecessary TDynBenchFn trait and remove a couple of unused attributes and feature gates.

The crate name is already set in Cargo.toml. The comment says there is
some logic in the compiler that reads #![crate_name] and not
--crate-name, but I can't find it. Removing it seems to work fine.
@bjorn3 bjorn3 added C-cleanup Category: PRs that clean code up or issues documenting cleanup. A-libtest Area: `#[test]` / the `test` library labels Dec 29, 2021
@rust-highfive
Copy link
Collaborator

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 29, 2021
@m-ou-se
Copy link
Member

m-ou-se commented Jan 3, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Jan 3, 2022

📌 Commit e015b9e has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 3, 2022
…askrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#90102 (Remove `NullOp::Box`)
 - rust-lang#92011 (Use field span in `rustc_macros` when emitting decode call)
 - rust-lang#92402 (Suggest while let x = y when encountering while x = y)
 - rust-lang#92409 (Couple of libtest cleanups)
 - rust-lang#92418 (Fix spacing in pretty printed PatKind::Struct with no fields)
 - rust-lang#92444 (Consolidate Result's and Option's methods into fewer impl blocks)

Failed merges:

 - rust-lang#92483 (Stabilize `result_cloned` and `result_copied`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 92f28bd into rust-lang:master Jan 3, 2022
@rustbot rustbot added this to the 1.59.0 milestone Jan 3, 2022
@bjorn3 bjorn3 deleted the libtest_cleanups branch January 3, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-libtest Area: `#[test]` / the `test` library C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants