Update hashbrown to 0.12.0

[Amanieu]

Changelog

[rust-highfive]

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

[Amanieu]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 2c3656b9d9d11327f285bec1531540d6d892435f with merge 0d9d73ee6d3cf25e92a024f7586015300a9ba2e4...

[bors]

☀️ Try build successful - checks-actions
Build commit: 0d9d73ee6d3cf25e92a024f7586015300a9ba2e4 (0d9d73ee6d3cf25e92a024f7586015300a9ba2e4)

[rust-timer]

Queued 0d9d73ee6d3cf25e92a024f7586015300a9ba2e4 with parent fd20513, future comparison URL.

[rust-timer]

Finished benchmarking commit (0d9d73ee6d3cf25e92a024f7586015300a9ba2e4): comparison url.

Summary: This change led to very large relevant mixed results 🤷 in compiler performance.

• Very large improvement in instruction counts (up to -9.3% on incr-patched: println builds of webrender opt)
• Large regression in instruction counts (up to 2.6% on incr-unchanged builds of externs debug)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

[Amanieu]

This seems like an overall win but with a bit of noise since this code is extremely sensitive to inlining.

[Mark-Simulacrum]

Agreed.

@bors r+

[bors]

📌 Commit 2c3656b9d9d11327f285bec1531540d6d892435f has been approved by Mark-Simulacrum

[bors]

⌛ Testing commit 2c3656b9d9d11327f285bec1531540d6d892435f with merge ac5c9425520abf5bfa3abb8f47288fa86abafa50...

[bors]

💔 Test failed - checks-actions

[Amanieu]

@bors r=Mark-Simulacrum

[bors]

📌 Commit 361a2f9 has been approved by Mark-Simulacrum

[bors]

⌛ Testing commit 361a2f9 with merge 90ad6b55f65fdfac80fda6c58f892afe3d8ea7a1...

[bors]

💔 Test failed - checks-actions

[Amanieu]

@bors r=Mark-Simulacrum

[bors]

📌 Commit 537439c has been approved by Mark-Simulacrum

[bors]

⌛ Testing commit 537439c with merge 91321b82ef6f989725ac5e41f5159dfa3075ecc1...

[bors]

💥 Test timed out

[Amanieu]

One of the apple builders seems very slow, it's 5 hours in and still building. I don't think it's related to this PR since perf showed no negative impact on bootstrap times.

@bors retry

[rust-log-analyzer]

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[bors]

⌛ Testing commit 537439c with merge 10c4c4a...

[bors]

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 10c4c4a to master...

[rust-timer]

Finished benchmarking commit (10c4c4a): comparison url.

Summary: This change led to very large relevant mixed results 🤷 in compiler performance.

• Very large improvement in instruction counts (up to -9.4% on incr-patched: println builds of webrender opt)
• Large regression in instruction counts (up to 2.5% on incr-unchanged builds of externs debug)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression