Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify [a]rc code a little #99113

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Simplify [a]rc code a little #99113

merged 1 commit into from
Jul 15, 2022

Conversation

WaffleLapkin
Copy link
Member

@WaffleLapkin WaffleLapkin commented Jul 10, 2022 •
edited
Loading

Nothing interesting, just make [a]rc code a little nicer by using byte_sub and let-else.

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jul 10, 2022
@rustbot
Copy link
Collaborator

rustbot commented Jul 10, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 10, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@thomcc
Copy link
Member

thomcc commented Jul 11, 2022

I'm not sure this is a change we want to make. There's an ongoing effort in #94971 and #94970 to reduce the number of unstable features used by the stdlib -- at least outside of libcore, and/or where not necessary.

As for where we can use these features in order to test them out / bikeshed them before landing, I think the idea is that the compiler is a better place for this than the stdlib (and hopefully they agree!), so that might be a better place to try a PR like this.

@WaffleLapkin
Copy link
Member Author

@thomcc Thanks for clarifying libs team intentions! I can remove the added use of let-else.

I think that byte_sub change is still meaningful though (+ I plan to propose stabilizing it, so it won't be unstable for long, hopefully :D).

@Mark-Simulacrum
Copy link
Member

At the very least, it would likely be a good idea to make an experience report comment linking to this PR on the byte_sub tracking issue -- IMO, the code is definitely nicer and more readable with it.

@WaffleLapkin
Copy link
Member Author

Update: rebased to remove let-else commit.

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jul 14, 2022

📌 Commit 69f8eb1 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 14, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Jul 15, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 15, 2022
@bors
Auto merge of rust-lang#99267 - Dylan-DPC:rollup-d8l7y1o, r=Dylan-DPC
522abf6 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#99113 (Simplify [a]rc code a little)
 - rust-lang#99131 (Add label for generic arg (+ APIT) and RPIT callables in `label_fn_like`)
 - rust-lang#99237 (removed unused CSS and unused HTML IDs)
 - rust-lang#99239 (Add myself to the set of people notified when MIR changes.)
 - rust-lang#99241 (Remove comment referring to constness.rs)
 - rust-lang#99257 (Add regression test for rust-lang#89436)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 99f3132 into rust-lang:master Jul 15, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 15, 2022
@WaffleLapkin WaffleLapkin deleted the arc_simplify branch August 19, 2022 11:53
@WaffleLapkin WaffleLapkin mentioned this pull request Sep 4, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.
7 participants
@WaffleLapkin @rustbot @rust-highfive @rust-log-analyzer @thomcc @Mark-Simulacrum @bors