Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement prefetch data intrinsics #420

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NCGThompson
Copy link
Contributor

Fixes #414

It should probably have tests that should fail before the changes. What kind of test should I add?

I edited the builtin list in context.rs, and that might create a conflict when syncing with the rust repository.

@antoyo
Copy link
Contributor

antoyo commented Jan 29, 2024

It should probably have tests that should fail before the changes. What kind of test should I add?

Do you know what kind of tests there is for this in the LLVM codegen?

@NCGThompson
Copy link
Contributor Author

The codegen tests are probably the most thorough, but they are LLVM specific. However, according to the FileCheck documentation, it doesn't do much that can't be done with grep.

At a minimum though, I think we should check that the compiler can encounter the function without panicking.

@antoyo
Copy link
Contributor

antoyo commented Feb 1, 2024

At a minimum though, I think we should check that the compiler can encounter the function without panicking.

I would be OK with such a test. You can add it in this directory.

@antoyo
Copy link
Contributor

antoyo commented Feb 28, 2024

Is this still a draft or should I review this PR?

@NCGThompson NCGThompson marked this pull request as ready for review March 25, 2024 03:44
@antoyo
Copy link
Contributor

antoyo commented Sep 3, 2024

Oh, sorry, I didn't notice you marked this PR as ready for review (please ping me if I don't answer for some time: I can easily miss some things).

There are some conflicts to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minimal implimentation of prefetch
2 participants