Fix load alignment being applied to referenced value #551
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some code I compiled, the
align
argument (edit: inBuilder::load
) wasn't the same as the pointer's regular alignment, and gcc ended up dereferencing the wrong address. So I think thealign
argument is meant to only apply to the loaded value and not to the one that's being read.For comparison, rustc_codegen_llvm does the following: